Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry Pick #956 into release-0.4 #981

Merged
merged 1 commit into from
Jan 11, 2022

Conversation

robscott
Copy link
Member

@robscott robscott commented Jan 8, 2022

What type of PR is this?
/kind bug

What this PR does / why we need it:
This cherry-picks #956 into the release-0.4 branch in advance of a v0.4.1 release.

Does this PR introduce a user-facing change?:

Introduced PreciseHostname which prevents wildcard characters in relevant Hostname values. 

…card value and precise value for hostnames.

Updates the HTTPRequestRedirectFilter.Hostname to use the new PreciseHostname type which validates the value cannot
contain wildcard characters.

Signed-off-by: Steve Sloka <slokas@vmware.com>
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 8, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2022
@brianehlert
Copy link
Contributor

I am not following the use case why this is required.
I understand there is some link to validation enforcement, but that seems more like an implementation convenience than a feature that makes the api easier to use.

@robscott
Copy link
Member Author

@brianehlert That's a good question. This change actually tightens validation, which is technically backwards incompatible. We're trying to get as many of these changes out of the way while the API is still in alpha. The rationale for even allowing this change in is that the previously allowed value was entirely invalid and not implementable. Redirecting to *.example.com does not make sense.

@hbagdi
Copy link
Contributor

hbagdi commented Jan 11, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 11, 2022
@k8s-ci-robot k8s-ci-robot merged commit 1b0c4f7 into kubernetes-sigs:release-0.4 Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants