Rename ParentRef to be consistent with other reference types. #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/cleanup
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jpeach The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
hbagdi
reviewed
Jan 11, 2022
Across the API, the object reference types are all called `FooBarReference`. To be consistent with this pattern, `ParentRef` should be called `ParentReference`. Signed-off-by: James Peach <jpeach@apache.org>
jpeach
force-pushed
the
rename-parent-ref
branch
from
d339674
to
f510f74
Compare
k8s-ci-robot
added
size/XS
|
LGTM. |
|
Thanks! /lgtm |
k8s-ci-robot
added
the
lgtm
mmalecki
added a commit
to mmalecki/contour
that referenced
this pull request
Mar 7, 2022
`ParentRef` -> `ParentReference`, as per kubernetes-sigs/gateway-api#982.
mmalecki
added a commit
to mmalecki/contour
that referenced
this pull request
Apr 15, 2022
`ParentRef` -> `ParentReference`, as per kubernetes-sigs/gateway-api#982.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Across the API, the object reference types are all called
FooBarReference. To be consistent with this pattern,ParentRefshould be called
ParentReference.A few issues with this PR
Which issue(s) this PR fixes:
N/A
Does this PR introduce a user-facing change?: