Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sparkles: upgrade gcr.io/kubebuilder/kube-rbac-proxy from v0.5.0 to v0.7.0 #1686

Conversation

camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented Sep 21, 2020

Description
upgrade gcr.io/kubebuilder/kube-rbac-proxy from v0.5.0 to v0.7.0

Motivtion
Address security issues/concerns since now it is rootless.

IMPORTANT: It has no breaking changes: https://github.com/brancz/kube-rbac-proxy/releases/tag/v0.7.0

Closes: #1637

TODO: Built the image gcr.io/kubebuilder/kube-rbac-proxy based on https://github.com/brancz/kube-rbac-proxy/releases/tag/v0.7.0

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 21, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 21, 2020
@camilamacedo86 camilamacedo86 changed the title upgrade gcr.io/kubebuilder/kube-rbac-proxy from v0.5.0 to v0.7.0 ✨ upgrade gcr.io/kubebuilder/kube-rbac-proxy from v0.5.0 to v0.7.0 Sep 21, 2020
@camilamacedo86 camilamacedo86 changed the title ✨ upgrade gcr.io/kubebuilder/kube-rbac-proxy from v0.5.0 to v0.7.0 WIP: ✨ upgrade gcr.io/kubebuilder/kube-rbac-proxy from v0.5.0 to v0.7.0 Sep 21, 2020
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 21, 2020
@akgunjal
Copy link

@camilamacedo86 : By when the image gcr.io/kubebuilder/kube-rbac-proxy:v0.7.0 will be available in the registry?

@camilamacedo86
Copy link
Member Author

Hi @akgunjal,

This image has been built/pushed manually. For this scenario I think that still valid we build/push the image manually based on the release tag v0.7.0. The idea is that this project will be donated to k8s org and then, we will able to automate this process easily. However, we need a hand for someone who has permissions to do that.

@vincepri @droot @DirectXMan12 @mengqiy could you give a hand with it?

@camilamacedo86 camilamacedo86 changed the title WIP: ✨ upgrade gcr.io/kubebuilder/kube-rbac-proxy from v0.5.0 to v0.7.0 sparkles: upgrade gcr.io/kubebuilder/kube-rbac-proxy from v0.5.0 to v0.7.0 Oct 27, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 27, 2020
@camilamacedo86
Copy link
Member Author

I am closing this one because we are unable to move forward to use the latest releases until we have the #1785 done.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 16, 2020
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 20, 2021

@camilamacedo86: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubebuilder-e2e-k8s-1-16-2 ccfe7e2 link /test pull-kubebuilder-e2e-k8s-1-16-2
pull-kubebuilder-e2e-k8s-1-18-0 ccfe7e2 link /test pull-kubebuilder-e2e-k8s-1-18-0
pull-kubebuilder-e2e-k8s-1-17-0 ccfe7e2 link /test pull-kubebuilder-e2e-k8s-1-17-0
pull-kubebuilder-e2e-k8s-1-15-3 ccfe7e2 link /test pull-kubebuilder-e2e-k8s-1-15-3

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploying manager pod as non-root
3 participants