Don't let find search filesystem mounts in docker build run step #10131

tomodachi · 2023-05-24T19:44:22Z

What type of PR is this?
kind bug

What this PR does / why we need it:
Fixes bug causing failure to build the ansible docker image with podman

Which issue(s) this PR fixes:
#10130

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Don't let find search filesystem mounts in docker build run step

linux-foundation-easycla · 2023-05-24T19:44:28Z

The committers listed above are authorized under a signed CLA.

✅ login: tomodachi / name: Mateusz Mojsiejuk (be9f442)

k8s-ci-robot · 2023-05-24T19:44:30Z

Welcome @tomodachi!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2023-05-24T19:44:31Z

Hi @tomodachi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

MrFreezeex · 2023-05-25T00:40:16Z

Dockerfile

@@ -38,4 +38,4 @@ RUN apt update -q \
    && echo $(curl -L https://dl.k8s.io/release/$KUBE_VERSION/bin/linux/$(dpkg --print-architecture)/kubectl.sha256) /usr/local/bin/kubectl | sha256sum --check \
    && chmod a+x /usr/local/bin/kubectl \
    && rm -rf /var/lib/apt/lists/* /var/log/* \
-    && find / -type d -name '*__pycache__' -prune -exec rm -rf {} \;
+    && find / -mount -type d -name '*__pycache__' -prune -exec rm -rf {} \;


It should be sufficient to only look into the workdir and prevent the issue your are having IMO

Suggested change

&& find / -mount -type d -name '*__pycache__' -prune -exec rm -rf {} \;

&& find . -type d -name '*__pycache__' -prune -exec rm -rf {} \;

Ah wait no that's for pip dep and they are installed system wide... But actually there is already the no compile flag to pip so I guess we could simply remove this?

It's true that they shouldn't be created when pip is run with the no-compile flag

But examining this in a live docker container I realized that pycache files are created anyway.
They are created when the python3 python3-pip packages are installed.
So the find -prune is still useful as it will free up 17mb.

I've updated my PR to only search the /usr folder which is where the pycache files are located
Instead of searching the whole filesystem and ignoring mount points

Thanks for the additional insight! Could you squash your commits? Apart from that lgtm.

yankay · 2023-05-25T02:10:52Z

/ok-to-test

floryut

@tomodachi Thank you 👍

k8s-ci-robot · 2023-05-31T08:03:51Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, tomodachi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [floryut]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

yankay · 2023-06-05T02:17:04Z

HI @tomodachi

Would you please re-push the PR to trigger the CI again :-)
Thank you

Limit find cmd to /usr/ where __pycache__ files are located

yankay · 2023-06-06T08:12:28Z

/lgtm

…10131) Limit find cmd to /usr/ where __pycache__ files are located

Limit find cmd to /usr/ where __pycache__ files are located Co-authored-by: Mateusz Mojsiejuk <m@fishface.se>

…10131) Limit find cmd to /usr/ where __pycache__ files are located

k8s-ci-robot requested a review from bozzo May 24, 2023 19:44

k8s-ci-robot requested a review from yankay May 24, 2023 19:44

k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 24, 2023

k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 24, 2023

MrFreezeex reviewed May 25, 2023

View reviewed changes

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 25, 2023

tomodachi force-pushed the fix_podman_build_fail branch from ecfa13e to 6e73554 Compare May 30, 2023 19:31

floryut approved these changes May 31, 2023

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2023

floryut added the kind/feature Categorizes issue or PR as related to a new feature. label May 31, 2023

Payback159 mentioned this pull request Jun 2, 2023

Release Proposal v2.22.1 #10179

Closed

yankay force-pushed the fix_podman_build_fail branch 2 times, most recently from 8b81b7d to 3ce4424 Compare June 6, 2023 03:03

Don't search filesystem mounts in docker build step

be9f442

Limit find cmd to /usr/ where __pycache__ files are located

yankay force-pushed the fix_podman_build_fail branch from 3ce4424 to be9f442 Compare June 6, 2023 03:10

k8s-ci-robot assigned yankay Jun 6, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 6, 2023

k8s-ci-robot merged commit 18d84db into kubernetes-sigs:master Jun 6, 2023

yankay pushed a commit to yankay/kubespray that referenced this pull request Jun 6, 2023

Don't search filesystem mounts in docker build step (kubernetes-sigs#…

ec8af16

…10131) Limit find cmd to /usr/ where __pycache__ files are located

yankay mentioned this pull request Jun 6, 2023

[2.22] Don't search filesystem mounts in docker build step (#10131) #10194

Merged

yankay pushed a commit to yankay/kubespray that referenced this pull request Jun 6, 2023

Don't search filesystem mounts in docker build step (kubernetes-sigs#…

e930366

…10131) Limit find cmd to /usr/ where __pycache__ files are located

k8s-ci-robot pushed a commit that referenced this pull request Jun 6, 2023

Don't search filesystem mounts in docker build step (#10131) (#10194)

2cf23e3

Limit find cmd to /usr/ where __pycache__ files are located Co-authored-by: Mateusz Mojsiejuk <m@fishface.se>

palmeXx pushed a commit to palmeXx/kubespray that referenced this pull request Jun 7, 2023

Don't search filesystem mounts in docker build step (kubernetes-sigs#…

652aff7

…10131) Limit find cmd to /usr/ where __pycache__ files are located

tomodachi deleted the fix_podman_build_fail branch June 12, 2023 10:19

maciej-markowski pushed a commit to maciej-markowski/kubespray that referenced this pull request Jun 23, 2023

Don't search filesystem mounts in docker build step (kubernetes-sigs#…

b6d8036

…10131) Limit find cmd to /usr/ where __pycache__ files are located

yankay mentioned this pull request Aug 24, 2023

Release Proposal v2.23 #10389

Closed

VannTen mentioned this pull request Feb 5, 2024

Release proposal 2.22.2 #10880

Closed

pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024

Don't search filesystem mounts in docker build step (kubernetes-sigs#…

ce23667

…10131) Limit find cmd to /usr/ where __pycache__ files are located

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Don't let find search filesystem mounts in docker build run step #10131

Don't let find search filesystem mounts in docker build run step #10131

tomodachi commented May 24, 2023 •

edited by floryut

Loading

linux-foundation-easycla bot commented May 24, 2023 •

edited

Loading

k8s-ci-robot commented May 24, 2023

k8s-ci-robot commented May 24, 2023

MrFreezeex May 25, 2023

MrFreezeex May 25, 2023 •

edited

Loading

tomodachi May 29, 2023 •

edited

Loading

MrFreezeex May 29, 2023 •

edited

Loading

yankay commented May 25, 2023

floryut left a comment

k8s-ci-robot commented May 31, 2023

yankay commented Jun 5, 2023

yankay commented Jun 6, 2023

	&& find / -mount -type d -name '*__pycache__' -prune -exec rm -rf {} \;
	&& find . -type d -name '*__pycache__' -prune -exec rm -rf {} \;

Don't let find search filesystem mounts in docker build run step #10131

Don't let find search filesystem mounts in docker build run step #10131

Conversation

tomodachi commented May 24, 2023 • edited by floryut Loading

linux-foundation-easycla bot commented May 24, 2023 • edited Loading

k8s-ci-robot commented May 24, 2023

k8s-ci-robot commented May 24, 2023

MrFreezeex May 25, 2023

Choose a reason for hiding this comment

MrFreezeex May 25, 2023 • edited Loading

Choose a reason for hiding this comment

tomodachi May 29, 2023 • edited Loading

Choose a reason for hiding this comment

MrFreezeex May 29, 2023 • edited Loading

Choose a reason for hiding this comment

yankay commented May 25, 2023

floryut left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented May 31, 2023

yankay commented Jun 5, 2023

yankay commented Jun 6, 2023

tomodachi commented May 24, 2023 •

edited by floryut

Loading

linux-foundation-easycla bot commented May 24, 2023 •

edited

Loading

MrFreezeex May 25, 2023 •

edited

Loading

tomodachi May 29, 2023 •

edited

Loading

MrFreezeex May 29, 2023 •

edited

Loading