boostrap-os: use import_tasks instead of symlinks #11508
Conversation
k8s-ci-robot
added
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: VannTen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
Working symlinks are dependant on git configuration (when using the playbook as a git repository, which is common), precisely `git config core.symlinks`. While this is enabled by default, some company policies will disable it. Instead, use import_tasks which should avoid that class of bugs.
VannTen
force-pushed
the
fix/dont_use_symlinks
branch
from
91bc673
to
33146db
Compare
|
/cherrypick release-2.25 |
|
@VannTen: once the present PR merges, I will cherry-pick it on top of release-2.25 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Thanks @VannTen |
k8s-ci-robot
added
the
lgtm
|
@VannTen: new pull request created: #11509 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Working symlinks are dependant on git configuration (when using the playbook as
a git repository, which is common), precisely
git config core.symlinks.While this is enabled by default, some company policies will disable it.
Instead, use import_tasks which should avoid that class of bugs.
Which issue(s) this PR fixes:
Fixes #11152
Does this PR introduce a user-facing change?: