Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update defaults to match k8s 1.12 suggestions #3760

Merged
merged 5 commits into from
Nov 26, 2018
Merged

Update defaults to match k8s 1.12 suggestions #3760

merged 5 commits into from
Nov 26, 2018

Conversation

woopstar
Copy link
Member

With k8s 1.12 as default now, let's update several defaults as well.

Possible fixes #3465 too

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 26, 2018
@woopstar
Copy link
Member Author

ci check this

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 26, 2018
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 26, 2018
@riverzhang
Copy link
Contributor

https://github.com/kubernetes-incubator/kubespray/blob/master/roles/kubespray-defaults/defaults/main.yaml#L47
https://github.com/kubernetes-incubator/kubespray/blob/master/roles/kubespray-defaults/defaults/main.yaml#L18
@woopstar need update too.

@riverzhang
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 26, 2018
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 26, 2018
@woopstar
Copy link
Member Author

https://github.com/kubernetes-incubator/kubespray/blob/master/roles/kubespray-defaults/defaults/main.yaml#L47
https://github.com/kubernetes-incubator/kubespray/blob/master/roles/kubespray-defaults/defaults/main.yaml#L18
@woopstar need update too.

Fixed

@chadswen
Copy link
Member

kube_proxy_mode: iptables is also in /roles/kubespray-defaults/defaults/main.yaml

@chadswen
Copy link
Member

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 26, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chadswen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2018
@chadswen
Copy link
Member

RE: netchecker localhost changes with ipvs, there's an issue and a PR for that upstream:
kubernetes/kubernetes#67730
kubernetes/kubernetes#69206

@k8s-ci-robot k8s-ci-robot merged commit bad886c into kubernetes-sigs:master Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapsuk chapsuk Awaiting requested review from chapsuk

@jjungnickel jjungnickel Awaiting requested review from jjungnickel

Assignees

@chadswen chadswen

@riverzhang riverzhang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@woopstar @riverzhang @chadswen @k8s-ci-robot