-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set configure-cloud-routes=false as default if no network plugin is used #3788
Set configure-cloud-routes=false as default if no network plugin is used #3788
Conversation
As configure-cloud-routes default value is `true`, so it need to be set to `false` when not required to avoid error messages like: "Couldn't reconcile node routes: error listing routes: unable to find route table for AWS cluster" on, for example, AWS installations that don't use cloud native routing.
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
signed CLA. |
roles/kubernetes/master/templates/manifests/kube-controller-manager.manifest.j2
Outdated
Show resolved
Hide resolved
ci check this |
remove extra spaces
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: karbyshevds, woopstar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…sed (kubernetes-sigs#3788) * Set configure-cloud-routes=false as default if no network plugin is used As configure-cloud-routes default value is `true`, so it need to be set to `false` when not required to avoid error messages like: "Couldn't reconcile node routes: error listing routes: unable to find route table for AWS cluster" on, for example, AWS installations that don't use cloud native routing. * Update kube-controller-manager.manifest.j2 remove extra spaces
As configure-cloud-routes default value is
true
, so it need to be set tofalse
when not required to avoid error messages like:"Couldn't reconcile node routes: error listing routes: unable to find route table for AWS cluster"
on, for example, AWS installations that don't use cloud native routing.