Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nginx-ingress: bump up version to 1.0.4 in the README #8124

Merged
merged 3 commits into from
Oct 25, 2021
Merged

nginx-ingress: bump up version to 1.0.4 in the README #8124

merged 3 commits into from
Oct 25, 2021

Conversation

mzaian
Copy link
Contributor

@mzaian mzaian commented Oct 25, 2021

What type of PR is this?
/kind bug

What this PR does / why we need it:
Just document the new version in the README

Which issue(s) this PR fixes:
Release notes https://github.com/kubernetes/ingress-nginx/releases/tag/controller-v1.0.4

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
Ingress-nginx: upgrade to 1.0.4

@mzaian
nginx-ingress: bump to 1.0.4
4030c9a 
* Disable builtin ssl_session_cache solving the problem with OpenSSL consuming memory.
* Print warning only instead of error if no IngressClass permission is available.
@mzaian
Merge branch 'kubernetes-sigs:master' into master
0aaca39
@mzaian
nginx-ingress: bump to 1.0.4 in the README
45b62e8
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 25, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @mzaian. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 25, 2021
@mzaian
Copy link
Contributor Author

mzaian commented Oct 25, 2021

Sorry forgot to add the corresponding version in the README in the previous PR

floryut
floryut approved these changes Oct 25, 2021
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, forgot that too, thanks for fixing
/lgtm
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 25, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, mzaian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2021
@k8s-ci-robot k8s-ci-robot merged commit c2d4822 into kubernetes-sigs:master Oct 25, 2021
notCalle pushed a commit to ModioAB/kubespray that referenced this pull request Feb 8, 2022
@mzaian @notCalle
nginx-ingress: bump up version to 1.0.4 in the README (kubernetes-sig…
0016d13 
…s#8124)

* nginx-ingress: bump to 1.0.4

* Disable builtin ssl_session_cache solving the problem with OpenSSL consuming memory.
* Print warning only instead of error if no IngressClass permission is available.

* nginx-ingress: bump to 1.0.4 in the README

(cherry picked from commit c2d4822)
notCalle pushed a commit to ModioAB/kubespray that referenced this pull request Feb 10, 2022
@mzaian @notCalle
nginx-ingress: bump up version to 1.0.4 in the README (kubernetes-sig…
9bee2fa 
…s#8124)

* nginx-ingress: bump to 1.0.4

* Disable builtin ssl_session_cache solving the problem with OpenSSL consuming memory.
* Print warning only instead of error if no IngressClass permission is available.

* nginx-ingress: bump to 1.0.4 in the README

(cherry picked from commit c2d4822)
notCalle pushed a commit to ModioAB/kubespray that referenced this pull request Feb 10, 2022
@mzaian @notCalle
nginx-ingress: bump up version to 1.0.4 in the README (kubernetes-sig…
44a45ac 
…s#8124)

* nginx-ingress: bump to 1.0.4

* Disable builtin ssl_session_cache solving the problem with OpenSSL consuming memory.
* Print warning only instead of error if no IngressClass permission is available.

* nginx-ingress: bump to 1.0.4 in the README

(cherry picked from commit c2d4822)
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
@mzaian @sakuraiyuta
nginx-ingress: bump up version to 1.0.4 in the README (kubernetes-sig…
11be36c 
…s#8124)

* nginx-ingress: bump to 1.0.4

* Disable builtin ssl_session_cache solving the problem with OpenSSL consuming memory.
* Print warning only instead of error if no IngressClass permission is available.

* nginx-ingress: bump to 1.0.4 in the README
@mzaian mzaian mentioned this pull request Jun 9, 2022
Closed
9 tasks
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 27, 2023
@mzaian @LuckySB
nginx-ingress: bump up version to 1.0.4 in the README (kubernetes-sig…
2e5bafe 
…s#8124)

* nginx-ingress: bump to 1.0.4

* Disable builtin ssl_session_cache solving the problem with OpenSSL consuming memory.
* Print warning only instead of error if no IngressClass permission is available.

* nginx-ingress: bump to 1.0.4 in the README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryut floryut floryut approved these changes

@bozzo bozzo Awaiting requested review from bozzo

@jayonlau jayonlau Awaiting requested review from jayonlau

Assignees

@floryut floryut

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mzaian @k8s-ci-robot @floryut