etcd: add etcd v3.5.1 for kubernetes 1.22+

[mzaian]

What type of PR is this?

/kind feature

What this PR does / why we need it:
There is an issue with etcd v3.5.0 where it resurrects ancient members see: etcd-io/etcd#13196
This issue is fixed in etcd v3.5.2
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[etcd] add v3.5.1 for kubernetes 1.22+

[k8s-ci-robot]

Hi @mzaian. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[linux-foundation-easycla]

The committers are authorized under a signed CLA.

• ✅ Mohamed Zaian (4030c9a, 0aaca39, 45b62e8, 8dc6502, 611f34d, c25f339, c16097a, 67036ce, 0952746, 206fa98, 4727a0e, 4ecc3d3)

[floryut]

@mzaian You really have to cleanup your git history :)
And as far as I see in the issue, the problem was fixed in 3.5.1 .. or is it something I'm missing ?

Usually we try to follow etcd version from k8s, but if there is indeed a messy bug we can bump a minor version.

[mzaian]

Hello @floryut ,
So first when I tried with version 3.5.0 I had the issue. Tried version 3.5.2 with another cluster it worked smoothly with a k8s cluster that is running 1.21.

[cristicalin]

So first when I tried with version 3.5.0 I had the issue. Tried version 3.5.2 with another cluster it worked smoothly with a k8s cluster that is running 1.21.

As pointed out by @floryut , this issue seems to be addressed in 3.5.1 already, when upstream suggests moving to 3.5.2 (with kube 1.24 maybe) we should bump the default unless there is a specific need to do it earlier. I would suggest to just add the relevant checksums so deployers such as yourself can decide for themselves to upgrade individual clusters but leave the default to 3.5.1.

[mzaian]

So first when I tried with version 3.5.0 I had the issue. Tried version 3.5.2 with another cluster it worked smoothly with a k8s cluster that is running 1.21.

As pointed out by @floryut , this issue seems to be addressed in 3.5.1 already, when upstream suggests moving to 3.5.2 (with kube 1.24 maybe) we should bump the default unless there is a specific need to do it earlier. I would suggest to just add the relevant checksums so deployers such as yourself can decide for themselves to upgrade individual clusters but leave the default to 3.5.1.

I modified my PR, but I kept the etcd v3.5.1 for k8s 1.22 because it has the fix.

[cristicalin]

Thank you @mzaian !

/ok-to-test
/lgtm

[floryut]

@mzaian Fine by me for this version 👍

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, mzaian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [floryut]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment