-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle empty namespace as default #5430
fix: handle empty namespace as default #5430
Conversation
/kind bug |
b09fa07
to
894bf8a
Compare
This PR has multiple commits, and the default merge method is: merge. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the changes to go.work.sum
be removed as well?
The code changes for the fix lgtm - though I am not an official reviewer.
/lgtm Thanks for the fix, code changes LGTM. Please ping me for approval once you confirm from @ncapps's comment above if the go.work.sum file is correctly updated |
Update the namespace handling in the edit add configmap and secret commands to handle the empty namespace and the default namespace in the same way. Before this change, if a configmap/secret was created using kustomize edit add where one command was issued with default as the namespace and the other without a namespace specified it would create two separate configmap generators, and then kustomize build would fail if merge was not the strategy for either.
Run go mod tidy to remove references of golang.org/x/exp, that was used during development but later removed.
6a95c1d
to
73c9875
Compare
I've undone the changes to |
08b0f69
to
623f963
Compare
8a4cd19
to
623f963
Compare
Revert changes made to go.work.sum, since they don't pertain to code changed in this PR.
623f963
to
4d7b8ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: natasha41575, stormqueen1990 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
Update the namespace handling in the
edit add configmap
/edit add secret
commands to handle the empty namespace as ifdefault
was specified.Before this change, if
configMapGenerators
/secretGenerators
were created usingkustomize edit add
where one command was issued withdefault
as the namespace and another without a namespace specified, Kustomize created two separateconfigMapGenerators
/secretGenerators
, and then failed duringkustomize build
if the strategy didn't merge both.