Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

releng: Bump promoter to v3.5.0 #753

Merged
merged 1 commit into from
Mar 15, 2023
Merged

releng: Bump promoter to v3.5.0 #753

merged 1 commit into from
Mar 15, 2023

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Feb 28, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • releng: Bump promoter to v3.5.0

/assign @puerco @saschagrunert @ameukam
cc @kubernetes-sigs/release-engineering

Which issue(s) this PR fixes:

Related to:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

releng: Bump promoter to v3.5.0

@cpanato
releng: Bump promoter to v3.5.0
db323af 
Signed-off-by: cpanato <ctadeu@gmail.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 28, 2023
@cpanato
Copy link
Member Author

cpanato commented Feb 28, 2023

/hold

@cpanato cpanato mentioned this pull request Feb 28, 2023
Closed
8 tasks
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 28, 2023
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 28, 2023
@k8s-ci-robot k8s-ci-robot added area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 28, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 28, 2023
@ameukam
Copy link
Member

ameukam commented Feb 28, 2023

/lgtm

palnabarun
palnabarun approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@palnabarun palnabarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, palnabarun, saschagrunert, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cpanato,palnabarun,saschagrunert,xmudrii]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cpanato
Copy link
Member Author

cpanato commented Mar 2, 2023

going to hold till next week

@upodroid
Copy link
Member

Can we merge this change first? #669

@cpanato
Copy link
Member Author

cpanato commented Mar 14, 2023

Can we merge this change first? #669

we also are waiting for other things

@upodroid upodroid mentioned this pull request Mar 14, 2023
Merged
@cpanato
Copy link
Member Author

cpanato commented Mar 15, 2023

ok, we have what we need for this release

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 15, 2023
@k8s-ci-robot k8s-ci-robot merged commit 1454285 into kubernetes-sigs:main Mar 15, 2023
@cpanato cpanato deleted the release-3-5-0 branch March 15, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@palnabarun palnabarun palnabarun approved these changes

@xmudrii xmudrii xmudrii approved these changes

@cici37 cici37 Awaiting requested review from cici37

@jeremyrickard jeremyrickard Awaiting requested review from jeremyrickard

Assignees

@saschagrunert saschagrunert

@ameukam ameukam

@puerco puerco

@palnabarun palnabarun

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@cpanato @ameukam @k8s-ci-robot @upodroid @saschagrunert @palnabarun @xmudrii @puerco