Change signature annotation to version #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
area/release-eng
k8s-ci-robot
added
size/S
Before this commit, we used to annotate the image signatures with a record of the mirrors where we promoted the images. We need an anotation in order to force cosign to add a signature to images which are already promoted. BNut now we are promoting to dozens of registries and it has made the original annotation cumbersome and bloated. This commit changes the annotation to record the promoter version instead. Signed-off-by: Adolfo García Veytia (Puerco) <puerco@chainguard.dev>
k8s-ci-robot
added
size/M
cpanato
approved these changes
Mar 29, 2023
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, puerco, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Before this commit, we used to annotate the image signatures with a record of the mirrors where we promoted the images. We need an annotation in order to force cosign to add a signature to images which are already promoted.
But now we are promoting to dozens of registries and it has made the original annotation cumbersome and bloated.
This PR changes the annotation to record the promoter version instead.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
/assign @xmudrii @jeremyrickard
Does this PR introduce a user-facing change?