Merge pull request #362 from chrisamert/addUpdateStrategyToHelmParame…

…ters Allow the 'updateStrategy' of the Daemonset to be configured in Helm
kubernetes-sigs · Oct 28, 2020 · a7458eb · a7458eb
2 parents 35f5312 + 8be9e33
commit a7458eb
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 0 deletions.
diff --git a/manifest_staging/charts/secrets-store-csi-driver/README.md b/manifest_staging/charts/secrets-store-csi-driver/README.md
@@ -42,6 +42,7 @@ The following table lists the configurable parameters of the csi-secrets-store-p
 | `linux.livenessProbe.resources`         | The resource request/limits for the linux liveness-probe container image                                                          | `limits: 100m CPU, 100Mi; requests: 10m CPU, 20Mi`               |
 | `linux.env`                             | Environment variables to be passed for the daemonset on linux nodes                                                               | `[]`                                                             |
 | `linux.priorityClassName`               | Indicates the importance of a Pod relative to other Pods.                                                                         | `""`                                                             |
+| `linux.updateStrategy`                  | Configure a custom update strategy for the daemonset on linux nodes                                                               | `RollingUpdate with 1 maxUnavailable`                            |
 | `windows.image.repository`              | Windows image repository                                                                                                          | `us.gcr.io/k8s-artifacts-prod/csi-secrets-store/driver`          |
 | `windows.image.pullPolicy`              | Windows image pull policy                                                                                                         | `IfNotPresent`                                                   |
 | `windows.image.tag`                     | Windows image tag                                                                                                                 | `v0.0.16`                                                        |
@@ -61,6 +62,7 @@ The following table lists the configurable parameters of the csi-secrets-store-p
 | `windows.livenessProbe.resources`       | The resource request/limits for the windows liveness-probe container image                                                        | `limits: 200m CPU, 200Mi; requests: 10m CPU, 20Mi`               |
 | `windows.env`                           | Environment variables to be passed for the daemonset on windows nodes                                                             | `[]`                                                             |
 | `windows.priorityClassName`             | Indicates the importance of a Pod relative to other Pods.                                                                         | `""`                                                             |
+| `windows.updateStrategy`                | Configure a custom update strategy for the daemonset on windows nodes                                                             | `RollingUpdate with 1 maxUnavailable`                            |
 | `logLevel.debug`                        | Enable debug logging                                                                                                              | true                                                             |
 | `livenessProbe.port`                    | Liveness probe port                                                                                                               | `9808`                                                           |
 | `livenessProbe.logLevel`                | Liveness probe container logging verbosity level                                                                                  | `2`                                                              |

diff --git a/...t_staging/charts/secrets-store-csi-driver/templates/secrets-store-csi-driver-windows.yaml b/...t_staging/charts/secrets-store-csi-driver/templates/secrets-store-csi-driver-windows.yaml
@@ -9,6 +9,8 @@ spec:
   selector:
     matchLabels:
       app: {{ template "sscd.name" . }}
+  updateStrategy:
+{{ toYaml .Values.windows.updateStrategy | indent 4 }}
   template:
     metadata:
 {{ include "sscd.labels" . | indent 6 }}

diff --git a/manifest_staging/charts/secrets-store-csi-driver/templates/secrets-store-csi-driver.yaml b/manifest_staging/charts/secrets-store-csi-driver/templates/secrets-store-csi-driver.yaml
@@ -9,6 +9,8 @@ spec:
   selector:
     matchLabels:
       app: {{ template "sscd.name" . }}
+  updateStrategy:
+{{ toYaml .Values.linux.updateStrategy | indent 4 }}
   template:
     metadata:
 {{ include "sscd.labels" . | indent 6 }}

diff --git a/manifest_staging/charts/secrets-store-csi-driver/values.yaml b/manifest_staging/charts/secrets-store-csi-driver/values.yaml
@@ -42,6 +42,11 @@ linux:
         cpu: 10m
         memory: 20Mi
 
+  updateStrategy:
+    type: RollingUpdate
+    rollingUpdate:
+      maxUnavailable: 1
+
   kubeletRootDir: /var/lib/kubelet
   nodeSelector: {}
   tolerations: []
@@ -93,6 +98,11 @@ windows:
         cpu: 10m
         memory: 20Mi
 
+  updateStrategy:
+    type: RollingUpdate
+    rollingUpdate:
+      maxUnavailable: 1
+
   kubeletRootDir: C:\var\lib\kubelet
   nodeSelector: {}
   tolerations: []