Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add docs for ingress tls with vault #212

Merged
merged 2 commits into from
May 29, 2020
Merged

docs: add docs for ingress tls with vault #212

merged 2 commits into from
May 29, 2020

Conversation

aramase
Copy link
Member

@aramase aramase commented May 29, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 29, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aramase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2020
@k8s-ci-robot k8s-ci-robot requested a review from ritazh May 29, 2020 01:33
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 29, 2020
@aramase
Copy link
Member Author

aramase commented May 29, 2020

/test pull-secrets-store-csi-driver-e2e-azure

@aramase aramase force-pushed the vault-ingress branch 3 times, most recently from 7412b2d to 5d69d20 Compare May 29, 2020 03:17
ritazh
ritazh reviewed May 29, 2020
View reviewed changes
docs/README.ingress-tls.md Outdated
@@ -0,0 +1,9 @@
# Using Secrets Store CSI to Enable NGINX Ingress Controller with TLS

Copy link
Member

@ritazh ritazh May 29, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we already have links that point to sample/ingress-controller-tls/README.md, how about we replace the content with this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! Kept the change minimal and updated sample/ingress-controller-tls/README.md.

ritazh
ritazh reviewed May 29, 2020
View reviewed changes
sample/ingress-controller-tls/README.md Outdated
* issuer: CN=demo.test.com; O=ingress-tls
* SSL certificate verify result: self signed certificate (18), continuing anyway.
```
- [Using Secrets Store CSI and Azure Key Vault Provider](https://github.com/Azure/secrets-store-csi-driver-provider-azure/blob/master/sample/ingress-controller/README.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The folder here should be consistent across all repos. how about sample/ingress-controller-tls?

@aramase
Copy link
Member Author

aramase commented May 29, 2020

/hold

Will be merged after Azure/secrets-store-csi-driver-provider-azure#113 and hashicorp/vault-csi-provider#42 are merged

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 29, 2020
@ritazh
Copy link
Member

ritazh commented May 29, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 29, 2020
@ritazh
Copy link
Member

ritazh commented May 29, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 29, 2020
@k8s-ci-robot k8s-ci-robot merged commit 1e0b187 into kubernetes-sigs:master May 29, 2020
@aramase aramase deleted the vault-ingress branch May 29, 2020 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritazh ritazh ritazh left review comments

Assignees

@ritazh ritazh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aramase @k8s-ci-robot @ritazh