Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add vault provider to grpc supported providers #434

Merged
merged 1 commit into from
Jan 27, 2021
Merged

chore: add vault provider to grpc supported providers #434

merged 1 commit into from
Jan 27, 2021

Conversation

aramase
Copy link
Member

@aramase aramase commented Jan 26, 2021

What this PR does / why we need it:

  • Adds vault to gRPC supported providers
    • Doing this as part of the next release because the driver invoking provider binary logic will be removed with the next release.

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 26, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2021
@aramase
Copy link
Member Author

aramase commented Jan 26, 2021

cc @tomhjp

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 26, 2021
@aramase aramase added this to the v0.0.20 milestone Jan 26, 2021
tomhjp
tomhjp approved these changes Jan 26, 2021
View reviewed changes
Copy link
Contributor

@tomhjp tomhjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks for raising this, I had meant to ask because I wasn't sure whether it was necessary with the next release due to deprecate invoking binaries.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aramase, tomhjp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tam7t
Copy link
Contributor

tam7t commented Jan 27, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 27, 2021
@k8s-ci-robot k8s-ci-robot merged commit f6bde52 into kubernetes-sigs:master Jan 27, 2021
@aramase aramase deleted the add-vault-grpc-provider branch January 27, 2021 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomhjp tomhjp tomhjp approved these changes

@ritazh ritazh Awaiting requested review from ritazh

@tam7t tam7t Awaiting requested review from tam7t

Assignees

@tam7t tam7t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v0.0.20
Development

Successfully merging this pull request may close these issues.
4 participants
@aramase @k8s-ci-robot @tam7t @tomhjp