Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use our own fork of go-yaml #264

Merged
merged 1 commit into from
Oct 6, 2024
Merged

Conversation

aojea
Copy link
Contributor

@aojea aojea commented Oct 5, 2024

We have our own fork of go-yaml kubernetes-sigs/yaml#76 so we can simplify the dependency graph in kubernetes if we end the path in kubernetes-sigs/yaml

go mod why gopkg.in/yaml.v2
# gopkg.in/yaml.v2
k8s.io/apiextensions-apiserver/examples/client-go/pkg/client/applyconfiguration/internal
sigs.k8s.io/structured-merge-diff/v4/typed
gopkg.in/yaml.v2

Change-Id: I87fd9303c9f582efacadad79df00b3b98a696bd0
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 5, 2024
@aojea
Copy link
Contributor Author

aojea commented Oct 5, 2024

/assign @liggitt @dims

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 5, 2024
@dims
Copy link
Member

dims commented Oct 6, 2024

/approve
/lgtm

/assign @apelisse @jpbetz

(root OWNERS in this repo)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 6, 2024
@jpbetz
Copy link
Contributor

jpbetz commented Oct 6, 2024

/approve

Thanks @aojea!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, dims, jpbetz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2024
@k8s-ci-robot k8s-ci-robot merged commit f034ec0 into kubernetes-sigs:master Oct 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants