Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix [CVE-2023-27561](https://github.com/advisories/GHSA-vpvm-3wq2-2wvm) #2326

Merged
merged 1 commit into from
Apr 7, 2023
Merged

Fix [CVE-2023-27561](https://github.com/advisories/GHSA-vpvm-3wq2-2wvm) #2326

merged 1 commit into from
Apr 7, 2023

Conversation

mpatlasov
Copy link
Contributor

What this PR does / why we need it

Update dependencies to runc v1.1.5 (which has opencontainers/runc#3773)

Which issue this PR fixes

Fixes opencontainers/runc#3751

Testing done:

make test

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 5, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @mpatlasov!

It looks like this is your first PR to kubernetes-sigs/vsphere-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/vsphere-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 5, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @mpatlasov. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 5, 2023
@mpatlasov mpatlasov changed the title Fix CVE-2023-27561 Fix [CVE-2023-27561](https://github.com/advisories/GHSA-vpvm-3wq2-2wvm) Apr 5, 2023
@mpatlasov
Copy link
Contributor Author

/assign @gnufied

@jsafrane
Copy link
Contributor

jsafrane commented Apr 6, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 6, 2023
@gnufied
Copy link
Contributor

gnufied commented Apr 6, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 6, 2023
@gnufied
Copy link
Contributor

gnufied commented Apr 6, 2023

/assign @divyenpatel

@divyenpatel
Copy link
Member

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divyenpatel, mpatlasov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2023
@k8s-ci-robot k8s-ci-robot merged commit eb3c6b5 into kubernetes-sigs:master Apr 7, 2023
mpatlasov added a commit to mpatlasov/vmware-vsphere-csi-driver that referenced this pull request Apr 8, 2023
@mpatlasov
UPSTREAM: 2326: Update opencontainers/runc for CVE-2023-27561 (kubern…
aa4f0ca 
…etes-sigs#2326)

Fix [CVE-2023-27561](GHSA-vpvm-3wq2-2wvm)

Updated using: `go mod tidy; go mod vendor`
@mpatlasov mpatlasov mentioned this pull request Apr 9, 2023
Merged
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/vmware-vsphere-csi-driver that referenced this pull request Apr 11, 2023
@mpatlasov
UPSTREAM: 2326: Update opencontainers/runc for CVE-2023-27561 (kubern…
d5a3a71 
…etes-sigs#2326)

Fix [CVE-2023-27561](GHSA-vpvm-3wq2-2wvm)

Updated using: `go mod tidy; go mod vendor`
mpatlasov added a commit to mpatlasov/vmware-vsphere-csi-driver that referenced this pull request Apr 11, 2023
@mpatlasov
UPSTREAM: 2326: Update opencontainers/runc for CVE-2023-27561 (kubern…
aafd83e 
…etes-sigs#2326)

Fix [CVE-2023-27561](GHSA-vpvm-3wq2-2wvm)

Updated using: `go mod tidy; go mod vendor`
mpatlasov added a commit to mpatlasov/vmware-vsphere-csi-driver that referenced this pull request Apr 11, 2023
@mpatlasov
UPSTREAM: 2326: Update opencontainers/runc for CVE-2023-27561 (kubern…
02e555f 
…etes-sigs#2326)

Fix [CVE-2023-27561](GHSA-vpvm-3wq2-2wvm)

Updated using: `go mod tidy; go mod vendor`
mpatlasov added a commit to mpatlasov/vmware-vsphere-csi-driver that referenced this pull request Apr 12, 2023
@mpatlasov
UPSTREAM: 2326: Update opencontainers/runc for CVE-2023-27561 (kubern…
5c6def8 
…etes-sigs#2326)

Fix [CVE-2023-27561](GHSA-vpvm-3wq2-2wvm)

Updated using: `go mod tidy; go mod vendor`
mpatlasov added a commit to mpatlasov/vmware-vsphere-csi-driver that referenced this pull request Apr 12, 2023
@mpatlasov
UPSTREAM: 2326: Update opencontainers/runc for CVE-2023-27561 (kubern…
938234c 
…etes-sigs#2326)

Fix [CVE-2023-27561](GHSA-vpvm-3wq2-2wvm)

Updated using: `go mod tidy; go mod vendor`
mpatlasov added a commit to mpatlasov/vmware-vsphere-csi-driver that referenced this pull request Apr 12, 2023
@mpatlasov
UPSTREAM: 2326: Update opencontainers/runc for CVE-2023-27561 (kubern…
be91684 
…etes-sigs#2326)

Fix [CVE-2023-27561](GHSA-vpvm-3wq2-2wvm)

Updated using: `go mod tidy; go mod vendor`
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/vmware-vsphere-csi-driver that referenced this pull request Apr 13, 2023
@mpatlasov
UPSTREAM: 2326: Update opencontainers/runc for CVE-2023-27561 (kubern…
bbd9d98 
…etes-sigs#2326)

Fix [CVE-2023-27561](GHSA-vpvm-3wq2-2wvm)

Updated using: `go mod tidy; go mod vendor`
chao007
chao007 reviewed Apr 17, 2023
View reviewed changes
go.sum
@@ -502,8 +502,9 @@ github.com/opencontainers/go-digest v1.0.0 h1:apOUWs51W5PlhuyGyz9FCeeBIOUDA/6nW8
github.com/opencontainers/go-digest v1.0.0/go.mod h1:0JzlMkj0TRzQZfJkVvzbP0HBR3IKzErnv2BNG4W4MAM=
github.com/opencontainers/image-spec v1.0.2 h1:9yCKha/T5XdGtO0q9Q9a6T5NUCsTn/DrBg0D7ufOcFM=
github.com/opencontainers/image-spec v1.0.2/go.mod h1:BtxoFyWECRxE4U/7sNtV5W15zMzWCbyJoFRP3s7yZA0=
github.com/opencontainers/runc v1.1.3 h1:vIXrkId+0/J2Ymu2m7VjGvbSlAId9XNRPhn2p4b+d8w=
github.com/opencontainers/runc v1.1.3/go.mod h1:1J5XiS+vdZ3wCyZybsuxXZWGrgSr8fFJHLXuG2PsnNg=
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mpatlasov Hi Seems there left one more runc v1.1.3 info.

Copy link
Contributor Author

@mpatlasov mpatlasov Apr 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chao007 We control only go.mod, while go.sum is auto-generated by go mod tidy. Go uses an algorithm called Minimal version selection (https://go.dev/ref/mod#minimal-version-selection) which can provide stale results, we have seen similar behavior in other repos too. The presence of "runc v1.1.3" in go.sum doesn't necessarily mean that we depends on that version, it is go.mod that matters.

rajguptavm pushed a commit to rajguptavm/vsphere-csi-driver that referenced this pull request Jul 20, 2023
@mpatlasov @rajguptavm
Fix [CVE-2023-27561](GHSA-vpvm-3wq2-2wvm) (kubernetes-sigs#2326)
06b7c40
@eshafaq1 eshafaq1 mentioned this pull request Aug 10, 2023
Closed
@mpatlasov mpatlasov mentioned this pull request Dec 22, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chao007 chao007 chao007 left review comments

@chethanv28 chethanv28 Awaiting requested review from chethanv28

@gnufied gnufied Awaiting requested review from gnufied

Assignees

@gnufied gnufied

@divyenpatel divyenpatel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CVE-2019-19921 re-introduction/regression
6 participants
@mpatlasov @k8s-ci-robot @jsafrane @gnufied @divyenpatel @chao007