Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additionalLabels chart value #3687

Merged
merged 1 commit into from
Dec 4, 2020

Conversation

mgarstecki
Copy link
Contributor

Allows adding arbitrary labels to manifests deployed by the chart.

My use case is for anti-affinity rules with other deployments: I want to define a label across all relevant deployments, then an antiAffinity rule on all of them.

Even though it could work through podLabels, I don't find that field great for this use case: it doesn't make much sense to add it to the deployment selector.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 11, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @mgarstecki!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 11, 2020
@mgarstecki mgarstecki mentioned this pull request Nov 11, 2020
@gjtempleton
Copy link
Member

gjtempleton commented Nov 15, 2020

HI @mgarstecki, thanks for the pull request!

If you could follow the bot's instructions for signing and verifying the CLA on this PR I'd be happy to give it a proper look over.
From a quick glance you'll need to also include a version bump in the Chart.yaml.

@mgarstecki
Copy link
Contributor Author

Thanks for the feedback @gjtempleton 🙂

I'm working on getting the CLA signed by my employer, I'll get back to you once that's done !

@mgarstecki
Copy link
Contributor Author

CLA signed, checking if it got picked up.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 16, 2020
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 23, 2020
@gjtempleton
Copy link
Member

Hey @mgarstecki, thanks for doing the work to get the CLA signed off.

This'll need a rebase, and a bump to the chart's minor version in the Chart.yaml, but other than that this looks good to me.

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 3, 2020
Allows adding arbitrary labels to manifests deployed by the chart.
@mgarstecki
Copy link
Contributor Author

Thank you for the review @gjtempleton !
PR rebased and release bumped :)

@gjtempleton
Copy link
Member

/lgtm
/approve

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gjtempleton, mgarstecki

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2020
@k8s-ci-robot k8s-ci-robot merged commit c899db8 into kubernetes:master Dec 4, 2020
@mgarstecki mgarstecki deleted the allowAdditionalLabels branch December 23, 2020 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants