-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additionalLabels chart value #3687
Add additionalLabels chart value #3687
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @mgarstecki! |
HI @mgarstecki, thanks for the pull request! If you could follow the bot's instructions for signing and verifying the CLA on this PR I'd be happy to give it a proper look over. |
Thanks for the feedback @gjtempleton 🙂 I'm working on getting the CLA signed by my employer, I'll get back to you once that's done ! |
CLA signed, checking if it got picked up. |
Hey @mgarstecki, thanks for doing the work to get the CLA signed off. This'll need a rebase, and a bump to the chart's minor version in the Chart.yaml, but other than that this looks good to me. |
53ffe63
to
eccb1fd
Compare
Allows adding arbitrary labels to manifests deployed by the chart.
eccb1fd
to
55d39f0
Compare
Thank you for the review @gjtempleton ! |
/lgtm Thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gjtempleton, mgarstecki The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Allows adding arbitrary labels to manifests deployed by the chart.
My use case is for anti-affinity rules with other deployments: I want to define a label across all relevant deployments, then an antiAffinity rule on all of them.
Even though it could work through
podLabels
, I don't find that field great for this use case: it doesn't make much sense to add it to the deployment selector.