-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ecr-credential-provider: Fix warning about no region in image ref #1030
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6b7eb16
to
d6fad2f
Compare
@mmerkes PTAL, I think you were the orig author |
CI seems ill lately. /retest |
/lgtm |
/triage accepted |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This log line is in the wrong place, should be when
region == ""
notregion != ""
.Which issue(s) this PR fixes:
Noticed in #1029
Special notes for your reviewer:
Does this PR introduce a user-facing change?: