Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle InvalidInstanceID.NotFound when tagging resources #448

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Handle InvalidInstanceID.NotFound when tagging resources #448

merged 1 commit into from
Aug 23, 2022

Conversation

saurav-agarwalla
Copy link
Contributor

@saurav-agarwalla saurav-agarwalla commented Aug 19, 2022 •
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it: We recently found an issue with Node Lifecycle Controller where it leaks node objects in some cases and as a result, this controller runs into errors when trying to tag the instances underlying those node objects. This PR handles those errors gracefully and ignores those resources.

Which issue(s) this PR fixes: N/A

Special notes for your reviewer: N/A

Does this PR introduce a user-facing change?: NONE

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 19, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @saurav-agarwalla. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 19, 2022
@saurav-agarwalla
Copy link
Contributor Author

Was trying to rebase #443 but somehow ended up closing this so opened this.

@nckturner
Copy link
Contributor

/ok-to-test
/triage accepted

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 19, 2022
This was referenced Aug 23, 2022
Merged
Merged
Closed
Merged
Merged
@wongma7
Copy link
Contributor

wongma7 commented Aug 23, 2022

do you have a link to the node lifecycle controller issue?

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 23, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2022
@wongma7
Copy link
Contributor

wongma7 commented Aug 23, 2022

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 23, 2022
@k8s-ci-robot k8s-ci-robot merged commit 543ca70 into kubernetes:master Aug 23, 2022
@saurav-agarwalla
Copy link
Contributor Author

do you have a link to the node lifecycle controller issue?

/lgtm /approve

#444

k8s-ci-robot added a commit that referenced this pull request Aug 23, 2022
@k8s-ci-robot
Merge pull request #462 from saurav-agarwalla/automated-cherry-pick-o…
a36acb6 
…f-#448-release-1.23

Automated cherry pick of #448: Handle InvalidInstanceID.NotFound when tagging resources
k8s-ci-robot added a commit that referenced this pull request Aug 23, 2022
@k8s-ci-robot
Merge pull request #460 from saurav-agarwalla/automated-cherry-pick-o…
8018ec8 
…f-#448-release-1.21

Automated cherry pick of #448: Handle InvalidInstanceID.NotFound when tagging resources
k8s-ci-robot added a commit that referenced this pull request Aug 23, 2022
@k8s-ci-robot
Merge pull request #463 from saurav-agarwalla/automated-cherry-pick-o…
d3497fe 
…f-#448-release-1.22

Automated cherry pick of #448: Handle InvalidInstanceID.NotFound when tagging resources
k8s-ci-robot added a commit that referenced this pull request Aug 25, 2022
@k8s-ci-robot
Merge pull request #459 from saurav-agarwalla/automated-cherry-pick-o…
fff2060 
…f-#448-release-1.20

Automated cherry pick of #448: Handle InvalidInstanceID.NotFound when tagging resources
@saurav-agarwalla saurav-agarwalla mentioned this pull request Jan 20, 2023
Closed
9 tasks
@ndbaker1 ndbaker1 mentioned this pull request Oct 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M00nF1sh M00nF1sh Awaiting requested review from M00nF1sh

@wongma7 wongma7 Awaiting requested review from wongma7

Assignees

@wongma7 wongma7

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@saurav-agarwalla @k8s-ci-robot @nckturner @wongma7