Enable prometheus provider for workqueue metrics #754
Conversation
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
needs-triage
|
This issue is currently awaiting triage. If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/XS
|
/assign @ndbaker1 |
|
@cartermckinnon: GitHub didn't allow me to assign the following users: ndbaker1. Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cartermckinnon
force-pushed
the
prometheus-workqueue-metrics
branch
from
6387c3b
to
31343a1
Compare
| @@ -126,14 +131,13 @@ func NewTaggingController( | |||
| rateLimitEnabled = false | |||
| } | |||
|
|
|||
| registerMetrics() | |||
There was a problem hiding this comment.
I noticed this was here, it belongs in init IMO.
| @@ -32,9 +32,14 @@ import ( | |||
| opt "k8s.io/cloud-provider-aws/pkg/controllers/options" | |||
| awsv1 "k8s.io/cloud-provider-aws/pkg/providers/v1" | |||
| nodehelpers "k8s.io/cloud-provider/node/helpers" | |||
| _ "k8s.io/component-base/metrics/prometheus/workqueue" // enable prometheus provider for workqueue metrics | |||
There was a problem hiding this comment.
oh cool, didn't realize this was all done with side effects via init
There was a problem hiding this comment.
Yeah assuming these built-in metrics do the job, I'd like to get rid of the other ones we have after 1.29 is cut. The workqueue should track processing time (dequeue latency), errors, size, etc.
|
@ndbaker1: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @hakman Can you take a look at this? I'd like to get it into the first 1.29 release |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman, ndbaker1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What type of PR is this?
/kind feature
What this PR does / why we need it:
This enables all the internal workqueue metrics. They're registered to the
legacyregistryas the existing metrics in the tagging controller are.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
I changed the name of the
workqueueinstance. Before this change, I don't think this is really being exposed in any way, so shouldn't matter.Does this PR introduce a user-facing change?: