Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch GCP list calls to paginated calls. #171

Closed
wants to merge 1 commit into from

Conversation

vinayakankugoyal
Copy link
Contributor

Updating list calls to compute APIs to use pagination.

@k8s-ci-robot
Copy link
Contributor

Hi @vinayakankugoyal. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 8, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vinayakankugoyal
To complete the pull request process, please assign calebamiles after the PR has been reviewed.
You can assign the PR to them by writing /assign @calebamiles in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 8, 2020
@mikedanese
Copy link
Member

/ok-to-test

Change LGTM.

cc @liggitt @cheftako to see if there are any concerns with the dependencies moving around.

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 12, 2020
@cheftako
Copy link
Member

/retest

@cheftako
Copy link
Member

/lgtm
Would like to let Jordan check the dependency changes.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2020
@k8s-ci-robot
Copy link
Contributor

@vinayakankugoyal: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
cloud-provider-gcp-e2e-create 63f5d38 link /test cloud-provider-gcp-e2e-create
cloud-provider-gcp-tests 63f5d38 link /test cloud-provider-gcp-tests

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liggitt
Copy link
Member

liggitt commented Nov 12, 2020

dep changes look good... looks like a build error in CI:

/workspace/.bazel/sandbox/processwrapper-sandbox/554/execroot/io_k8s_cloud_provider_gcp/vendor/go.etcd.io/etcd/clientv3/balancer/picker/err.go:25:30: cannot use &errPicker literal (type *errPicker) as type Picker in return argument:
	*errPicker does not implement Picker (wrong type for Pick method)
		have Pick(context.Context, balancer.PickInfo) (balancer.SubConn, func(balancer.DoneInfo), error)
		want Pick(balancer.PickInfo) (balancer.PickResult, error)
/workspace/.bazel/sandbox/processwrapper-sandbox/554/execroot/io_k8s_cloud_provider_gcp/vendor/go.etcd.io/etcd/clientv3/balancer/picker/roundrobin_balanced.go:37:3: cannot use &rrBalanced literal (type *rrBalanced) as type Picker in return argument:
	*rrBalanced does not implement Picker (wrong type for Pick method)
		have Pick(context.Context, balancer.PickInfo) (balancer.SubConn, func(balancer.DoneInfo), error)
		want Pick(balancer.PickInfo) (balancer.PickResult, error)

@vinayakankugoyal
Copy link
Contributor Author

dep changes look good... looks like a build error in CI:

/workspace/.bazel/sandbox/processwrapper-sandbox/554/execroot/io_k8s_cloud_provider_gcp/vendor/go.etcd.io/etcd/clientv3/balancer/picker/err.go:25:30: cannot use &errPicker literal (type *errPicker) as type Picker in return argument:
	*errPicker does not implement Picker (wrong type for Pick method)
		have Pick(context.Context, balancer.PickInfo) (balancer.SubConn, func(balancer.DoneInfo), error)
		want Pick(balancer.PickInfo) (balancer.PickResult, error)
/workspace/.bazel/sandbox/processwrapper-sandbox/554/execroot/io_k8s_cloud_provider_gcp/vendor/go.etcd.io/etcd/clientv3/balancer/picker/roundrobin_balanced.go:37:3: cannot use &rrBalanced literal (type *rrBalanced) as type Picker in return argument:
	*rrBalanced does not implement Picker (wrong type for Pick method)
		have Pick(context.Context, balancer.PickInfo) (balancer.SubConn, func(balancer.DoneInfo), error)
		want Pick(balancer.PickInfo) (balancer.PickResult, error)

Looks like we are affected by etcd-io/etcd#11563 and etcd-io/etcd#11154 (comment) which was fixed in 3.5.0 which hasn't been release yet.

@vinayakankugoyal
Copy link
Contributor Author

Abandoning this in favor of #179.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants