Fix development container #4875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shu-mutou
commented
Feb 6, 2020
•
shu-mutou
commented
- Ensure installing dependencies.
- Enable to pass K8S_DASHBOARD_NPM_CMD as env to run-npm-on-container.sh.
- Fix typo.
k8s-ci-robot
added
cncf-cla: yes
|
Actually instead of install Dashboard it should say install dependencies. |
k8s-ci-robot
added
the
approved
shu-mutou
force-pushed
the
dev-container
branch
from
c933753
to
7617cf5
Compare
maciaszczykm
reviewed
Feb 6, 2020
* Ensure installing dependencies. * Enable to pass K8S_DASHBOARD_NPM_CMD as env to run-npm-on-container.sh. * Fix typo.
shu-mutou
force-pushed
the
dev-container
branch
from
7617cf5
to
5019fc5
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floreks, shu-mutou The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #4875 +/- ##
======================================
Coverage 45.4% 45.4%
======================================
Files 214 214
Lines 9983 9983
Branches 94 94
======================================
Hits 4533 4533
Misses 5185 5185
Partials 265 265Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.