Adding Callouts and Fixing Links #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
/lgtm |
k8s-ci-robot
added
the
lgtm
ahmetb
requested changes
Aug 14, 2017
cassandra/README.md
Outdated
| kubectl edit statefulset cassandra | ||
| ``` | ||
| kubectl edit statefulset cassandra | ||
|
|
||
| This command opens an editor in your terminal. The line you need to change is `Replicas`. |
cassandra/README.md
Outdated
| The StatefulSet now contains 4 pods. | ||
| {: .note} | ||
|
|
||
| # Please edit the object below. Lines beginning with a '#' will be ignored, |
There was a problem hiding this comment.
can you use 3-backticks syntax instead of indentation for such long snippets?
Also use
```yaml
syntax to provide syntax highlighting in such snippets.
Changed `Replicas` to replica field Gave excerpt highlighted syntax
|
@ahmetb updated per your comments. Thanks! |
ahmetb
reviewed
Aug 14, 2017
cassandra/README.md
Outdated
| @@ -152,29 +152,31 @@ Use `kubectl edit` to modify the size of of a Cassandra StatefulSet. | |||
|
|
|||
| kubectl edit statefulset cassandra | |||
|
|
|||
| This command opens an editor in your terminal. The line you need to change is `Replicas`. | |||
| This command opens an editor in your terminal. The line you need to change is the replicas field. | |||
There was a problem hiding this comment.
capture replicas as replicas pls
|
@ahmetb done |
ahmetb
approved these changes
Aug 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding callout formatting and other small fixes to Cassandra tutorial.
Fixing download links for Guestbook.