Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mount FlexVolume directory in kube-controller-manager pod #6874

Merged
merged 1 commit into from
Jul 25, 2019

Conversation

kellanburket
Copy link
Contributor

Mounts the FlexVolume directory so that FlexVolumes with attach capability can run on KOPs clusters

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 3, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @kellanburket. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 3, 2019
@kellanburket
Copy link
Contributor Author

/assign @KashifSaadat

@kellanburket kellanburket changed the title Issue #6847 Mount FlexVolume directory in kube-controller-manager pod May 3, 2019
@kellanburket
Copy link
Contributor Author

Applies to Issue 6847

@rdrgmnzs
Copy link
Contributor

rdrgmnzs commented May 6, 2019

For clarity controller manager needs access to FlexVolume plugin when using attach-detach controller interface.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 6, 2019
@KashifSaadat
Copy link
Contributor

Thanks @kellanburket for the PR and apologies for taking so long to review this. I'll aim to validate early next week and drop an update here. 👍

@KashifSaadat
Copy link
Contributor

Sorry for the delay, thanks for the contribution!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 25, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KashifSaadat, kellanburket

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2019
@k8s-ci-robot k8s-ci-robot merged commit 8a146b1 into kubernetes:master Jul 25, 2019
@justinsb
Copy link
Member

justinsb commented Aug 1, 2019

FYI because of the issues with OSes with read-only filesystems, I cancelled the cherry-pick to 1.14. It should still make it to 1.15-alpha which we're also going to cut soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants