Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding documentation to mitigate workload outages on AWS #7292

Merged
merged 1 commit into from
Jul 24, 2019
Merged

Adding documentation to mitigate workload outages on AWS #7292

merged 1 commit into from
Jul 24, 2019

Conversation

endzyme
Copy link
Contributor

@endzyme endzyme commented Jul 19, 2019

When running the upgrade process to quickly roll all the master, you can enter a state which causes nodes to become NotReady. This can lead to nodes (potentially all nodes) being removed from ELBs managed by Kubernetes Services type LoadBalancer. In order to avoid this you can add an IAM policy which temporarily blocks Kubernetes from removing nodes from ELBs, thus mitigating the temporary reconciliation state.

@k8s-ci-robot
Copy link
Contributor

Welcome @endzyme!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 19, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @endzyme. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 19, 2019
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 19, 2019
@endzyme

This comment has been minimized.

@endzyme

This comment has been minimized.

When running the upgrade process to quickly roll all the master, you can
enter a state which causes nodes to become `NotReady`. This can lead to
nodes (potentially _all_ nodes) being removed from ELBs managed by
Kubernetes Services type LoadBalancer. In order to avoid this you can add
an IAM policy which temporarily blocks Kubernetes from removing nodes
from ELBs, thus mitigating the temporary reconciliation state.

Co-Authored-By: Ivan Fetch <ivan@fairwinds.com>
Co-Authored-By: Corey O'Brien <corey@fairwinds.com>
Co-Authored-By: FairwindsOps <opensource@fairwinds.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 19, 2019
@rifelpet
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 19, 2019
@chrisz100
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 23, 2019
@KashifSaadat
Copy link
Contributor

Thanks for the contribution @endzyme !

/retest
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrisz100, endzyme, KashifSaadat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [KashifSaadat,chrisz100]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 44723c3 into kubernetes:master Jul 24, 2019
k8s-ci-robot added a commit that referenced this pull request Aug 1, 2019
@drewwells
Copy link

When running the upgrade process to quickly roll all the master, you can enter a state which causes nodes to become NotReady. This can lead to nodes (potentially all nodes) being removed from ELBs managed by Kubernetes Services type LoadBalancer. In order to avoid this you can add an IAM policy which temporarily blocks Kubernetes from removing nodes from ELBs, thus mitigating the temporary reconciliation state.

@endzyme did this actually happen to you? This corner case sounds more reasonable if a network partition was encountered. while etcd is down, kube-apiserver is down, kcm can not get notready status. once kube-apiserver is back up, kubelets will be checking in to update ready status

@endzyme
Copy link
Contributor Author

endzyme commented Feb 12, 2020

Yes it was quite common on our upgrade pattern at my last company. I can't recall specifics after this amount of time but I might be able to put you in touch with others still at the company.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants