-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: change log level from error to info #465
Conversation
Welcome @caozhuozi! |
cc: @alexzielenski |
Thanks for catching this. That makes sense, will leave lgtm to Alex. If anything this seems more like a debug statement that wasn't taken out? Do we need a proper comment rather than just logging id and commentPath? /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: caozhuozi, Jefftree The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @Jefftree ! Yes, it looks like a debug statement. Let's see if @alexzielenski could give any suggestions about the logging context. |
It likely is a debug statement. I'm ok with it being removed also, Infof seems fine /lgtm |
I'm not sure why the code uses
Errorf
here while the result ofparseSymbolReference
isok
.I found this issue when I was using
openapi-gen.go
to generate the/test/integration/testdata/defaults
package (to have a try) and the following error logs appeared.But the files were generated successfully.
Hope I don't have any misunderstanding here.