Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dependabot #474

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Add dependabot #474

merged 1 commit into from
Jun 20, 2024

Conversation

lucacome
Copy link
Contributor

Adds dependabot to keep Go and GitHub Actions dependencies up to date.

@lucacome
Add dependabot
5d2ab2e 
Signed-off-by: Luca Comellini <luca.com@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 30, 2024
@Jefftree
Copy link
Member

/approve
/cc @alexzielenski any thoughts on this? I'm fine with adding

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jefftree, lucacome

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2024
@Jefftree
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2024
@k8s-ci-robot k8s-ci-robot merged commit e1a2242 into kubernetes:master Jun 20, 2024
4 checks passed
@lucacome lucacome deleted the add-dependabot branch June 20, 2024 16:28
@liggitt liggitt mentioned this pull request Aug 22, 2024
Merged
@liggitt
Copy link
Member

liggitt commented Aug 22, 2024

oof... this makes kube-openapi proactively bump all dependencies in ways that impact Kubernetes' API surface and makes us unable to actually consume kube-openapi updates. I don't think we want this done globally until we insulate ourselves from API breaks as a result of dependency bumps

xref https://github.com/kubernetes/kubernetes/pull/126787/files#r1727343696

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jefftree Jefftree Awaiting requested review from Jefftree

@sttts sttts Awaiting requested review from sttts

Assignees

@Jefftree Jefftree

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lucacome @Jefftree @k8s-ci-robot @liggitt