-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bubble up buildOperations error. #481
Bubble up buildOperations error. #481
Conversation
Welcome @godwinpang! |
Thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: austince, godwinpang, Jefftree The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Jefftree fixed the gofmt issue, could I get a followup lgtm? |
/lgtm |
Errors encountered in
buildOperations
should not fail silently.I ran into an issue where
BuildOpenAPISpecFromRoutes
(kube-openapi/pkg/builder/openapi.go
Line 52 in b456828
buildOperations
errors not being bubbled up.