Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate warning for persistent volume admission controller #52618

Merged
merged 1 commit into from
Sep 22, 2017
Merged

deprecate warning for persistent volume admission controller #52618

merged 1 commit into from
Sep 22, 2017

Conversation

dims
Copy link
Member

@dims dims commented Sep 17, 2017

What this PR does / why we need it:

deprecate warning for persistent volume admission controller

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Fixes #52617

Special notes for your reviewer:

Release note:

PersistentVolumeLabel admission controller is now deprecated.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 17, 2017
@k8s-github-robot k8s-github-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 17, 2017
@dims
Copy link
Member Author

dims commented Sep 17, 2017

/sig cluster-lifecycle

@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Sep 17, 2017
@dims
Copy link
Member Author

dims commented Sep 21, 2017

/retest

@luxas luxas added this to the v1.8 milestone Sep 21, 2017
@luxas
Copy link
Member

luxas commented Sep 21, 2017

cc @kubernetes/sig-api-machinery-pr-reviews @thockin @jagosan PTAL and merge for v1.8
FYI @jdumars

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Sep 21, 2017
@andrewsykim
Copy link
Member

Might be good to put a deprecation warning here as well https://github.com/kubernetes/kubernetes/blob/master/cmd/kube-apiserver/app/options/plugins.go#L74

@dims dims force-pushed the deprecate-pvl-admission-controller branch from 96f1ddb to 0d89353 Compare September 21, 2017 17:58
@dims
Copy link
Member Author

dims commented Sep 21, 2017

@andrewsykim you mean as a comment? as opposed to something that a end user can see in their logs?

@andrewsykim
Copy link
Member

@dims just as a comment there since you already adding the log warning

@dims dims force-pushed the deprecate-pvl-admission-controller branch from 0d89353 to cf3fe0b Compare September 21, 2017 18:36
@andrewsykim
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 21, 2017
@dims
Copy link
Member Author

dims commented Sep 21, 2017

/assign @derekwaynecarr @nikhiljindal

@mbohlool
Copy link
Contributor

cc @cheftako

@derekwaynecarr
Copy link
Member

/approve

@dims
Copy link
Member Author

dims commented Sep 21, 2017

@nikhiljindal @smarterclayton @liggitt one of you PTAL?

@smarterclayton
Copy link
Contributor

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsykim, derekwaynecarr, dims, smarterclayton

Associated issue: 52617

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2017
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here..

@k8s-github-robot k8s-github-robot merged commit 04673ab into kubernetes:master Sep 22, 2017
@dims dims deleted the deprecate-pvl-admission-controller branch November 16, 2017 22:05
This was referenced Feb 11, 2018
Merged
Merged
@andrewsykim andrewsykim mentioned this pull request May 25, 2018
Merged
This was referenced May 26, 2018
Merged
Closed
k8s-github-robot pushed a commit that referenced this pull request May 28, 2018
Merge pull request #64326 from andrewsykim/default-disable-pvl
9f280b6 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

disable PersistentVolumeLabel admission controller by default

**What this PR does / why we need it**:
Disables PersisntVolumeLabel admission controller by default. This was set for [deprecation since 1.8](#52618) so we can now disable it by default. PersisntVolumeLabel admission controller can still be explicitly enabled and can also run on external cloud controller manageres. 

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:

#52617

**Special notes for your reviewer**:

**Release note**:

```release-note
(ACTION REQUIRED) PersisntVolumeLabel admission controller is now disabled by default. If you depend on this feature (AWS/GCE) then ensure it is added to the `--enable-admission-plugins` flag on the kube-apiserver.
```
@neolit123 neolit123 mentioned this pull request May 29, 2018
Closed
@Nuru Nuru mentioned this pull request Apr 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@derekwaynecarr derekwaynecarr

@nikhiljindal nikhiljindal

@andrewsykim andrewsykim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.

Remove the PersistentVolumeLabel Admission Controller
9 participants
@dims @luxas @andrewsykim @mbohlool @derekwaynecarr @smarterclayton @k8s-github-robot @nikhiljindal @k8s-ci-robot