Deb package: make sure to update the package metadata #10420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
sharifelgamal
approved these changes
Feb 17, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund, sharifelgamal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
priyawadhwa
reviewed
Feb 24, 2021
There was a problem hiding this comment.
Looks like lint is failing:
hack/update/github.go:231:14: SA1019: semver.Max is deprecated: use Compare instead. In most cases, returning a canonicalized version is not expected or desired. (staticcheck)
stable = semver.Max(ver, stable)
^
hack/update/github.go:233:14: SA1019: semver.Max is deprecated: use Compare instead. In most cases, returning a canonicalized version is not expected or desired. (staticcheck)
latest = semver.Max(ver, latest)
Probably just stale PR Fixed in |
The revision/release was hardcoded as 0
And let the template decide where they go
afbjorklund
force-pushed
the
package-metadata
branch
from
b3b9043
to
4cdf2c7
Compare
|
nice! |
ilya-zuyev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The revision/release was hardcoded as 0
Closes #10264