auto-detect gce and do not enable gcp auth addon #10730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
medyagh
requested changes
Mar 6, 2021
sharifelgamal
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
sharifelgamal
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
|
kvm2 Driver Times for Minikube (PR 10730): 68.9s 71.4s 76.1s Averages Time Per Log docker Driver Times for Minikube (PR 10730): 30.6s 27.8s 32.5s Averages Time Per Log |
|
kvm2 Driver Times for Minikube (PR 10730): 68.9s 70.8s 70.5s Averages Time Per Log docker Driver Times for Minikube (PR 10730): 27.8s 32.7s 32.3s Averages Time Per Log |
medyagh
requested changes
Mar 9, 2021
|
kvm2 Driver Times for Minikube (PR 10730): 62.0s 60.8s 60.8s Averages Time Per Log docker Driver Times for Minikube (PR 10730): 26.6s 27.9s 30.7s Averages Time Per Log |
medyagh
requested changes
Mar 9, 2021
k8s-ci-robot
added
size/L
|
kvm2 Driver Times for Minikube (PR 10730): 60.5s 62.7s 62.1s Averages Time Per Log docker Driver Times for Minikube (PR 10730): 28.3s 27.3s 28.0s Averages Time Per Log |
medyagh
requested changes
Mar 9, 2021
medyagh
requested changes
Mar 9, 2021
|
kvm2 Driver Times for Minikube (PR 10730): 60.8s 62.2s 61.4s Averages Time Per Log docker Driver Times for Minikube (PR 10730): 26.3s 28.3s 29.1s Averages Time Per Log |
|
kvm2 Driver Times for Minikube (PR 10730): 60.2s 59.9s 60.6s Averages Time Per Log docker Driver Times for Minikube (PR 10730): 28.6s 27.0s 26.8s Averages Time Per Log |
|
/ok-to-test |
|
kvm2 Driver Times for Minikube (PR 10730): 60.6s 60.3s 61.1s Averages Time Per Log docker Driver Times for Minikube (PR 10730): 27.4s 26.8s 27.7s Averages Time Per Log |
medyagh
requested changes
Mar 9, 2021
|
kvm2 Driver Times for Minikube (PR 10730): 62.0s 60.5s 62.5s Averages Time Per Log docker Driver Times for Minikube (PR 10730): 27.2s 27.3s 26.8s Averages Time Per Log |
|
kvm2 Driver Times for Minikube (PR 10730): 58.6s 61.4s 61.8s Averages Time Per Log docker Driver Times for Minikube (PR 10730): 26.1s 26.6s 24.9s Averages Time Per Log |
medyagh
approved these changes
Mar 10, 2021
medyagh
requested changes
Mar 10, 2021
There was a problem hiding this comment.
looks good just the test needs to be fixed
=== PAUSE TestAddons/parallel/GCPAuth
=== CONT TestAddons/parallel/GCPAuth
=== CONT TestAddons/parallel/GCPAuth
addons_test.go:570: (dbg) Run: kubectl --context addons-20210310004204-1084876 create -f testdata/busybox.yaml
=== CONT TestAddons/parallel/GCPAuth
addons_test.go:576: (dbg) TestAddons/parallel/GCPAuth: waiting 8m0s for pods matching "integration-test=busybox" in namespace "default" ...
helpers_test.go:335: "busybox" [066317cf-b496-4329-b73f-29969f50f4d9] Pending
helpers_test.go:335: "busybox" [066317cf-b496-4329-b73f-29969f50f4d9] Pending / Ready:ContainersNotReady (containers with unready status: [busybox]) / ContainersReady:ContainersNotReady (containers with unready status: [busybox])
helpers_test.go:335: "busybox" [066317cf-b496-4329-b73f-29969f50f4d9] Running
=== CONT TestAddons/parallel/GCPAuth
addons_test.go:576: (dbg) TestAddons/parallel/GCPAuth: integration-test=busybox healthy within 9.045320876s
addons_test.go:582: (dbg) Run: kubectl --context addons-20210310004204-1084876 exec busybox -- /bin/sh -c "printenv GOOGLE_APPLICATION_CREDENTIALS"
=== CONT TestAddons/parallel/GCPAuth
addons_test.go:582: (dbg) Non-zero exit: kubectl --context addons-20210310004204-1084876 exec busybox -- /bin/sh -c "printenv GOOGLE_APPLICATION_CREDENTIALS": exit status 1 (211.270025ms)
** stderr **
command terminated with exit code 1
** /stderr **
addons_test.go:584: printenv creds: exit status 1
|
kvm2 Driver Times for Minikube (PR 10730): 61.1s 60.1s 62.2s Averages Time Per Log docker Driver Times for Minikube (PR 10730): 27.2s 25.9s 27.2s Averages Time Per Log |
|
kvm2 Driver Times for Minikube (PR 10730): 67.6s 64.1s 66.2s Averages Time Per Log docker Driver Times for Minikube (PR 10730): 27.7s 28.8s 26.9s Averages Time Per Log |
medyagh
approved these changes
Mar 10, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh, sharifelgamal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9651
Fixes #10669