Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add output parameter to the docker-env none shell #12263

Merged
merged 2 commits into from
Aug 17, 2021

Conversation

afbjorklund
Copy link
Collaborator

@afbjorklund afbjorklund commented Aug 13, 2021

$ ./out/minikube docker-env --shell none --output json | jq
{
  "DOCKER_CERT_PATH": "/home/anders/.minikube/certs",
  "DOCKER_HOST": "tcp://192.168.49.2:2376",
  "DOCKER_TLS_VERIFY": "1",
  "MINIKUBE_ACTIVE_DOCKERD": "minikube"
}

Closes #12242

The test is actually longer than the code, due to the complexity in comparing maps and arrays in formats without sorting.

Allows structured output as json and yaml, in addition to the
previous text output format. Note that keys might not be sorted.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 13, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2021
@medyagh medyagh closed this Aug 17, 2021
@medyagh medyagh reopened this Aug 17, 2021
@medyagh medyagh merged commit 2df63c0 into kubernetes:master Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider adding JSON/key value pair output to docker-env command
3 participants