Fix addon registry doesn't follow Minikube DNS domain name configuration (--dns-domain)

[rogeriomm]

• Registry bug
  minikube-with-bug-registry version
  minikube-with-bug-registry -p cluster-unfixed start --dns-domain cluster.xpt
  minikube-with-bug-registry -p cluster-unfixed status
  minikube-with-bug-registry -p cluster-unfixed addons enable registry
  kubectl -n kube-system get pods | grep registry-proxy-
  kubectl -n kube-system logs registry-proxy-m5v47 | head -n 3
  nc -v $(minikube -p cluster-unfixed ip) 5000
  minikube-with-bug-registry -p cluster-unfixed logs

logs-unfixed.txt

• Registry bug fixed
  minikube-master-fix-registry version
  minikube-master-fix-registry -p cluster-fixed start --dns-domain cluster.xpt
  minikube-master-fix-registry -p cluster-fixed status
  minikube-master-fix-registry -p cluster-fixed addons enable registry
  kubectl -n kube-system get pods | grep registry-proxy-
  kubectl -n kube-system logs registry-proxy-m5v47 | head -n 3
  nc -v $(minikube -p cluster-fixed ip) 5000
  minikube-master-fix-registry -p cluster-fixed ssh sudo cat /etc/kubernetes/addons/registry-proxy.yaml
  minikube-master-fix-registry -p cluster-fixed logs

logs-fixed.txt

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: rogeriomm / name: Rogerio (431a296)

[k8s-ci-robot]

Welcome @rogeriomm!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @rogeriomm. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[minikube-bot]

Can one of the admins verify this patch?

[medyagh]

thank you @rogeriomm for fixing this, do you mind sharing Before and After this PR minikube output in the PR description ?

[rogeriomm]

thank you @rogeriomm for fixing this, do you mind sharing Before and After this PR minikube output in the PR description ?

Done

[medyagh]

thank you for fixing this issue, look forward to see more contributions from you

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, rogeriomm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[medyagh]

/ok-to-test

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle rotten
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[rogeriomm]

/remove-lifecycle rotten

[rogeriomm]

/ok-to-test

[spowelljr]

/retest-this-please

[minikube-pr-bot]

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15585) |
+----------------+----------+---------------------+
| minikube start | 53.8s    | 53.4s               |
| enable ingress | 28.8s    | 28.0s               |
+----------------+----------+---------------------+

Times for minikube (PR 15585) start: 52.5s 53.6s 57.3s 52.4s 51.3s
Times for minikube start: 52.2s 54.6s 54.6s 55.3s 52.3s

Times for minikube ingress: 27.9s 28.4s 29.9s 30.0s 28.0s
Times for minikube (PR 15585) ingress: 28.4s 27.9s 27.9s 27.9s 28.0s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15585) |
+----------------+----------+---------------------+
| minikube start | 24.5s    | 24.0s               |
| enable ingress | 20.9s    | 21.1s               |
+----------------+----------+---------------------+

Times for minikube start: 25.8s 22.4s 24.3s 24.3s 25.9s
Times for minikube (PR 15585) start: 26.8s 23.6s 23.8s 23.6s 22.3s

Times for minikube ingress: 21.9s 19.9s 21.9s 20.4s 20.4s
Times for minikube (PR 15585) ingress: 21.0s 20.9s 20.5s 21.9s 21.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15585) |
+----------------+----------+---------------------+
| minikube start | 23.7s    | 23.1s               |
| enable ingress | 29.5s    | 28.7s               |
+----------------+----------+---------------------+

Times for minikube start: 23.5s 21.0s 25.1s 24.3s 24.6s
Times for minikube (PR 15585) start: 21.2s 23.4s 24.7s 23.8s 22.1s

Times for minikube ingress: 30.9s 30.9s 18.9s 20.0s 46.9s
Times for minikube (PR 15585) ingress: 18.9s 30.9s 30.9s 31.4s 31.4s

[minikube-pr-bot]

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Linux_docker_arm64	TestRunningBinaryUpgrade (gopogh)	1.84 (chart)
KVM_Linux	TestStartStop/group/default-k8s-diff-port/serial/AddonExistsAfterStop (gopogh)	3.07 (chart)
KVM_Linux	TestStartStop/group/default-k8s-diff-port/serial/Pause (gopogh)	3.07 (chart)
KVM_Linux	TestStartStop/group/default-k8s-diff-port/serial/SecondStart (gopogh)	3.07 (chart)
KVM_Linux	TestStartStop/group/default-k8s-diff-port/serial/UserAppExistsAfterStop (gopogh)	3.07 (chart)
QEMU_macOS	TestFunctional/parallel/TunnelCmd/serial/RunSecondTunnel (gopogh)	44.06 (chart)

To see the flake rates of all tests by environment, click here.

[medyagh]

thank you @rogeriomm for the PR and patience on the review time