Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kicbase/ISO: Update cri-dockerd from v0.3.1 to v0.3.2 #16506

Merged
merged 5 commits into from
May 18, 2023
Merged

Kicbase/ISO: Update cri-dockerd from v0.3.1 to v0.3.2 #16506

merged 5 commits into from
May 18, 2023

Conversation

spowelljr
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 15, 2023
@spowelljr
Copy link
Member Author

ok-to-build-image

@spowelljr
Copy link
Member Author

ok-to-build-iso

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 15, 2023
@minikube-bot
Copy link
Collaborator

Hi @spowelljr, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

@minikube-bot
Copy link
Collaborator

Hi @spowelljr, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 16, 2023
@minikube-pr-bot

This comment has been minimized.

Sign in to view
@minikube-pr-bot

This comment has been minimized.

Sign in to view
@medyagh
Copy link
Member

medyagh commented May 16, 2023

/retest-this-please

@minikube-pr-bot

This comment has been minimized.

Sign in to view
@minikube-pr-bot

This comment has been minimized.

Sign in to view
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 17, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 18, 2023
@spowelljr
Copy link
Member Author

ok-to-build-image

@minikube-bot
Copy link
Collaborator

Hi @spowelljr, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

@minikube-pr-bot

This comment has been minimized.

Sign in to view
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16506) |
+----------------+----------+---------------------+
| minikube start | 54.2s    | 52.6s               |
| enable ingress | 27.5s    | 28.6s               |
+----------------+----------+---------------------+

Times for minikube start: 52.8s 54.0s 55.4s 54.5s 54.3s
Times for minikube (PR 16506) start: 53.0s 52.5s 54.0s 51.0s 52.5s

Times for minikube ingress: 28.6s 29.2s 25.1s 27.1s 27.7s
Times for minikube (PR 16506) ingress: 29.2s 29.2s 28.6s 27.7s 28.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16506) |
+----------------+----------+---------------------+
| minikube start | 24.1s    | 23.1s               |
| enable ingress | 21.5s    | 20.8s               |
+----------------+----------+---------------------+

Times for minikube start: 24.4s 23.9s 24.9s 22.0s 25.2s
Times for minikube (PR 16506) start: 23.6s 24.9s 21.4s 21.0s 24.5s

Times for minikube ingress: 20.3s 21.4s 21.9s 22.3s 21.8s
Times for minikube (PR 16506) ingress: 20.8s 19.8s 20.8s 21.4s 21.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16506) |
+----------------+----------+---------------------+
| minikube start | 23.0s    | 22.0s               |
| enable ingress | 34.5s    | 31.3s               |
+----------------+----------+---------------------+

Times for minikube start: 22.9s 24.7s 19.9s 23.7s 23.7s
Times for minikube (PR 16506) start: 21.3s 20.6s 23.2s 21.5s 23.4s

Times for minikube ingress: 48.3s 31.3s 31.3s 31.3s 30.3s
Times for minikube (PR 16506) ingress: 32.3s 30.3s 32.3s 30.3s 31.3s

@minikube-pr-bot

This comment has been minimized.

Sign in to view
@medyagh
Copy link
Member

medyagh commented May 18, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 18, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh medyagh merged commit 88a09e9 into kubernetes:master May 18, 2023
@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
QEMU_macOS TestImageBuild/serial/Setup (gopogh) 0.00 (chart)
KVM_Linux TestStartStop/group/default-k8s-diff-port/serial/AddonExistsAfterStop (gopogh) 3.64 (chart)
KVM_Linux TestStartStop/group/default-k8s-diff-port/serial/Pause (gopogh) 3.64 (chart)
KVM_Linux TestStartStop/group/default-k8s-diff-port/serial/SecondStart (gopogh) 3.64 (chart)
KVM_Linux TestStartStop/group/default-k8s-diff-port/serial/UserAppExistsAfterStop (gopogh) 3.64 (chart)
KVM_Linux TestStartStop/group/default-k8s-diff-port/serial/VerifyKubernetesImages (gopogh) 3.64 (chart)
QEMU_macOS TestFunctional/parallel/CpCmd (gopogh) 3.80 (chart)
QEMU_macOS TestFunctional/parallel/DashboardCmd (gopogh) 3.80 (chart)
QEMU_macOS TestFunctional/parallel/DockerEnv/bash (gopogh) 3.80 (chart)
QEMU_macOS TestFunctional/parallel/FileSync (gopogh) 3.80 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageBuild (gopogh) 3.80 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageListTable (gopogh) 3.80 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh) 3.80 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh) 3.80 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageReloadDaemon (gopogh) 3.80 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageSaveToFile (gopogh) 3.80 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon (gopogh) 3.80 (chart)
QEMU_macOS TestFunctional/parallel/NodeLabels (gopogh) 3.80 (chart)
QEMU_macOS TestFunctional/parallel/NonActiveRuntimeDisabled (gopogh) 3.80 (chart)
QEMU_macOS TestFunctional/parallel/PersistentVolumeClaim (gopogh) 3.80 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/DeployApp (gopogh) 3.80 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/Format (gopogh) 3.80 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/HTTPS (gopogh) 3.80 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/JSONOutput (gopogh) 3.80 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/List (gopogh) 3.80 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/URL (gopogh) 3.80 (chart)
QEMU_macOS TestFunctional/parallel/StatusCmd (gopogh) 3.80 (chart)
QEMU_macOS TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh) 3.80 (chart)
QEMU_macOS TestFunctional/parallel/TunnelCmd/serial/AccessThroughDNS (gopogh) 3.80 (chart)
QEMU_macOS TestFunctional/parallel/TunnelCmd/serial/DNSResolutionByDig (gopogh) 3.80 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@spowelljr spowelljr deleted the updateCriDocker branch May 18, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

@medyagh medyagh Awaiting requested review from medyagh

Assignees

@medyagh medyagh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@spowelljr @minikube-bot @minikube-pr-bot @medyagh @k8s-ci-robot