Upgrade to k8s-v1.7 #1693
Merged
Upgrade to k8s-v1.7 #1693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added a godep-update-k8s script for upgrading. $ KUBE_VERSION ./hack/godeps/godep-update-k8s.sh * Added client-go version ldflags to localkube and minikube. The version package is now split in both kubernetes and client-go, so we need to supply both ldflags. * Change cross builds to use BUILD_IN_DOCKER * Add a patch for kube-proxy The setup of kube-proxy recently changed, making the registering of the component config a fatal error instead of a warning. This patch reverts it to be a warning, which is a no-op for us anyways since we don't supply a config file.
The k8s components are registering their flags on localkube, polluting the flag namespace. A 'version' flag was added, which conflicts with a localkube flag. Changing the name of this flag so that there is no conflict.
Also switch out-of-order format strings in test output.
k8s-ci-robot
added
the
cncf-cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1693 +/- ##
==========================================
- Coverage 38.77% 38.55% -0.22%
==========================================
Files 51 51
Lines 2664 2674 +10
==========================================
- Hits 1033 1031 -2
- Misses 1452 1463 +11
- Partials 179 180 +1
Continue to review full report at Codecov.
|
|
Was this just a rebase + merge from the 1.7 branch? |
dlorenc
approved these changes
Jul 13, 2017
|
Yup, small rebase conflict in the makefile, but that was easily resolved. |
This was referenced Jul 14, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.