Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add none driver to the supported list. #2728

Merged
merged 1 commit into from
Apr 17, 2018
Merged

Add none driver to the supported list. #2728

merged 1 commit into from
Apr 17, 2018

Conversation

dlorenc
Copy link
Contributor

@dlorenc dlorenc commented Apr 16, 2018

Fixes #2727

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 16, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlorenc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 16, 2018
r2d4
r2d4 reviewed Apr 17, 2018
View reviewed changes
Copy link
Contributor

@r2d4 r2d4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hyperkit needs to be there too. how did this list get changed?

@dlorenc
Copy link
Contributor Author

dlorenc commented Apr 17, 2018

hyperkit needs to be there too. how did this list get changed?

That one got added back in another PR.

@dlorenc dlorenc merged commit 258d1e1 into kubernetes:master Apr 17, 2018
@OlafSzmidt OlafSzmidt mentioned this pull request May 11, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r2d4 r2d4 r2d4 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dlorenc @k8s-ci-robot @r2d4