Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for s390x #4091

Merged
merged 1 commit into from
Apr 30, 2019
Merged

Adding support for s390x #4091

merged 1 commit into from
Apr 30, 2019

Conversation

salamani
Copy link
Contributor

PR for #2880 and recreating #2881 due to multiple conflicts in rebase

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 13, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @salamani. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 13, 2019
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@salamani
Copy link
Contributor Author

/assign @tstromberg

tstromberg
tstromberg suggested changes Apr 16, 2019
View reviewed changes
.gitignore Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
deploy/addons/dashboard/dashboard-dp.template Outdated Show resolved Hide resolved
deploy/addons/storage-provisioner/storage-provisioner.template Outdated Show resolved Hide resolved
pkg/minikube/constants/constants.go Outdated Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: salamani
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: tstromberg

If they are not already assigned, you can assign the PR to them by writing /assign @tstromberg in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tstromberg
Copy link
Contributor

/ok-to-test

@tstromberg
Copy link
Contributor

@minikube-bot OK to test

@salamani
Copy link
Contributor Author

@here any idea on these CI Failures? It looks good for me on my s390x as well as on amd64 machine.

@tstromberg
Copy link
Contributor

They appear to be flakes. Retrying.

@minikube-bot OK to test

@tstromberg tstromberg removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 25, 2019
@tstromberg tstromberg mentioned this pull request Apr 25, 2019
Closed
@tstromberg tstromberg merged commit d0a3b6f into kubernetes:master Apr 30, 2019
@tstromberg
Copy link
Contributor

Thank you for this epic contribution, @salamani! My sincere apologies for it taking so long for us to accept it.

I look forward to this paving the way for properly supporting other architectures.

This was referenced May 2, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tstromberg tstromberg tstromberg requested changes

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

@dlorenc dlorenc Awaiting requested review from dlorenc

Assignees

@tstromberg tstromberg

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@salamani @k8s-ci-robot @minikube-bot @tstromberg