Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a variety of bugs in docker-env output #6540

Merged
merged 2 commits into from
Feb 7, 2020

Conversation

tstromberg
Copy link
Contributor

Bugfixes:

  • Remove errant newline in powershell and cmd output docker-env command does not work in powershell (v1.7) #6524
  • Remove unnecessary semicolon in fish output
  • Fix corrupt unset output if --unset and --no-proxy are used together
  • Remove trailing tab from cmd, powershell, and emacs output
  • Remove incorrect comment from unset output

Other changes:

  • Now unsets with a single command in compatible environments
  • Minor rewording of comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 7, 2020
@tstromberg
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 7, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2020
@tstromberg tstromberg changed the title Improve docker-env command output Fix a variety of bugs in docker-env output Feb 7, 2020
@minikube-pr-bot
Copy link

Error: running mkcmp: exit status 1

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@5d59e83). Click here to learn what that means.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6540   +/-   ##
=========================================
  Coverage          ?   37.88%           
=========================================
  Files             ?      137           
  Lines             ?     8674           
  Branches          ?        0           
=========================================
  Hits              ?     3286           
  Misses            ?     4975           
  Partials          ?      413
Impacted Files Coverage Δ
cmd/minikube/cmd/env.go 57.37% <ø> (ø)
pkg/minikube/bootstrapper/bootstrapper.go 0% <ø> (ø)
cmd/minikube/cmd/start.go 22.1% <50%> (ø)

@medyagh
Copy link
Member

medyagh commented Feb 7, 2020

@tstromberg thank you for fixing up after my human errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants