Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block on preload download before extracting, fall back to caching images if it fails #6928

Merged
merged 4 commits into from
Mar 7, 2020
Merged

Block on preload download before extracting, fall back to caching images if it fails #6928

merged 4 commits into from
Mar 7, 2020

Conversation

priyawadhwa
Copy link

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 7, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: priyawadhwa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2020
@codecov-io
Copy link

Codecov Report

Merging #6928 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6928   +/-   ##
=======================================
  Coverage   37.01%   37.01%           
=======================================
  Files         144      144           
  Lines        9010     9010           
=======================================
  Hits         3335     3335           
  Misses       5253     5253           
  Partials      422      422

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 7, 2020
@tstromberg tstromberg changed the title fall back to caching images if preload fails Block on preload download before extracting, fall back to caching images if it fails Mar 7, 2020
medyagh
medyagh approved these changes Mar 7, 2020
View reviewed changes
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for this quick fix :)

@medyagh
Copy link
Member

medyagh commented Mar 7, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 7, 2020
@medyagh medyagh merged commit 2fe6b61 into kubernetes:master Mar 7, 2020
@fmotrifork fmotrifork mentioned this pull request Mar 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tstromberg tstromberg tstromberg approved these changes

@medyagh medyagh medyagh approved these changes

@blueelvis blueelvis Awaiting requested review from blueelvis

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@priyawadhwa @k8s-ci-robot @codecov-io @medyagh @tstromberg