Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNI: Update CRIO netconfig with matching subnet #8570

Merged
merged 2 commits into from
Jun 27, 2020

Conversation

tstromberg
Copy link
Contributor

@tstromberg tstromberg commented Jun 26, 2020

In hopes of avoiding failed to set bridge addr: could not add IP address to \"cni0\": permission denied" race condition seen at: https://storage.googleapis.com/minikube-builds/logs/8545/03ec6f9/Docker_Linux.html#fail_TestOffline%2fgroup%2fcrio

as a bonus, this PR also skips more weavenet CNI tests to avoid TestNetworkPlugins/group/custom-weave/DNS test flake:

https://storage.googleapis.com/minikube-builds/logs/8545/03ec6f9/VirtualBox_Linux.html#fail_TestNetworkPlugins%2fgroup%2fcustom-weave%2fDNS

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 26, 2020
@tstromberg
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 26, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2020
@minikube-pr-bot
Copy link

kvm2 Driver
docker Driver

Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only see crio related code, please update the PR description

@medyagh medyagh self-requested a review June 26, 2020 18:57
@tstromberg tstromberg merged commit cdc456a into kubernetes:master Jun 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants