Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add number of nodes for cluster in minikube profile list #9702

Merged
merged 1 commit into from
Nov 24, 2020

Conversation

daehyeok
Copy link
Contributor

fixes #6780
Add the Nodes column with the number of nodes the cluster has into
minikube profile list output.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 14, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @daehyeok!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @daehyeok. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 14, 2020
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@daehyeok
Copy link
Contributor Author

/check-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 14, 2020
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for this PR, do you mind putting in the output Before and After this PR ?

@daehyeok
Copy link
Contributor Author

@medyagh

before

|--------------|-----------|---------|--------------|------|---------|---------|
|   Profile    | VM Driver | Runtime |      IP      | Port | Version | Status  |
|--------------|-----------|---------|--------------|------|---------|---------|
| minikube     | hyperkit  | docker  | 192.168.64.5 | 8443 | v1.19.2 | Stopped |
| test-profile | hyperkit  | docker  | 192.168.64.3 | 8443 | v1.19.2 | Stopped |
|--------------|-----------|---------|--------------|------|---------|---------|

after

|--------------|-----------|---------|--------------|------|---------|---------|-------|
|   Profile    | VM Driver | Runtime |      IP      | Port | Version | Status  | Nodes |
|--------------|-----------|---------|--------------|------|---------|---------|-------|
| minikube     | hyperkit  | docker  | 192.168.64.5 | 8443 | v1.19.2 | Stopped |     3 |
| test-profile | hyperkit  | docker  | 192.168.64.3 | 8443 | v1.19.2 | Stopped |     1 |
|--------------|-----------|---------|--------------|------|---------|---------|-------|

@medyagh
Copy link
Member

medyagh commented Nov 20, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 20, 2020
@minikube-pr-bot
Copy link

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with Minikube (PR 9702): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/9702/minikube start --driver=kvm2]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/9702/minikube: exec format error
docker Driver
error collecting results for docker driver: timing run 0 with Minikube (PR 9702): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/9702/minikube start --driver=docker]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/9702/minikube: exec format error

@sharifelgamal
Copy link
Collaborator

What does the output look like when the clusters are Started instead of Stopped? I'm worried that this won't address the second part of #6780

fixes \kubernetes#6780
Add the Nodes column with the number of nodes the cluster has into
`minikube profile list` output.
@daehyeok
Copy link
Contributor Author

@sharifelgamal Oops, Are you mean error message?. Sorry i missed that part. i will check again.

@medyagh
Copy link
Member

medyagh commented Nov 23, 2020

/ok-to-test

@medyagh
Copy link
Member

medyagh commented Nov 24, 2020

@daehyeok it looks good, we still need to fix the Second part of the problem which is showing

❗  Found 1 invalid profile(s) ! 
	 p2-m02
|----------|-----------|---------|--------------|------|---------|---------|-------|
| Profile  | VM Driver | Runtime |      IP      | Port | Version | Status  | Nodes |
|----------|-----------|---------|--------------|------|---------|---------|-------|
| minikube | docker    | docker  | 192.168.49.2 | 8443 | v1.19.4 | Running |     1 |
| p2       | docker    | docker  | 192.168.59.2 | 8443 | v1.19.4 | Running |     2 |
|----------|-----------|---------|--------------|------|---------|---------|-------|
❗  Found 1 invalid profile(s) ! 
	 p2-m02
💡  You can delete them using the following command(s): 
	 $ minikube delete -p p2-m02 

Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daehyeok it looks good, we still need to fix the Second part of the problem which is showing

❗  Found 1 invalid profile(s) ! 
	 p2-m02
|----------|-----------|---------|--------------|------|---------|---------|-------|
| Profile  | VM Driver | Runtime |      IP      | Port | Version | Status  | Nodes |
|----------|-----------|---------|--------------|------|---------|---------|-------|
| minikube | docker    | docker  | 192.168.49.2 | 8443 | v1.19.4 | Running |     1 |
| p2       | docker    | docker  | 192.168.59.2 | 8443 | v1.19.4 | Running |     2 |
|----------|-----------|---------|--------------|------|---------|---------|-------|
❗  Found 1 invalid profile(s) ! 
	 p2-m02
💡  You can delete them using the following command(s): 
	 $ minikube delete -p p2-m02 

@medyagh medyagh merged commit 02511f1 into kubernetes:master Nov 24, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: daehyeok, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add number of nodes for cluster in minikube profile list
6 participants