Add OpenTelemetry tracing to minikube #9723

priyawadhwa · 2020-11-17T05:41:39Z

To try this PR, run:

MINIKUBE_GCP_PROJECT_ID=<project id> minikube start --output json --trace gcp

and you should be able to see output in the Cloud Trace UI

Adds OpenTelemetry tracing, with the GCP exporter, to minikube. Refer to MEP: #9587

priyawadhwa · 2020-11-17T05:42:35Z

/ok-to-test

minikube-pr-bot · 2020-11-17T05:53:34Z

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with Minikube (PR 9723): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/9723/minikube start --driver=kvm2]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/9723/minikube: exec format error
docker Driver
error collecting results for docker driver: timing run 0 with Minikube (PR 9723): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/9723/minikube start --driver=docker]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/9723/minikube: exec format error

…add-tracing

pkg/trace/gcp.go

site/content/en/docs/tutorials/telemetry.md

medyagh · 2020-11-24T18:42:47Z

cmd/minikube/cmd/start_flags.go

@@ -152,6 +153,7 @@ func initMinikubeFlags() {
 	startCmd.Flags().Bool(deleteOnFailure, false, "If set, delete the current cluster if start fails and try again. Defaults to false.")
 	startCmd.Flags().Bool(forceSystemd, false, "If set, force the container runtime to use sytemd as cgroup manager. Currently available for docker and crio. Defaults to false.")
 	startCmd.Flags().StringVarP(&outputFormat, "output", "o", "text", "Format to print stdout in. Options include: [text,json]")
+	startCmd.Flags().StringP(trace, "", "", "Send trace events. Options include: [gcp]")


how about adding a check in the validate flags that if the option is not gcp, yell at them and say the valid options are ...

I added the valid options to the error message that will be displayed, this is what it would look like:

$ minikube start --trace dne ❌ Exiting due to MK_USAGE: error initializing tracing: getting tracer: dne is not a valid tracer, valid tracers include: [gcp]

minikube-pr-bot · 2020-11-24T18:43:37Z

kvm2 Driver
Times for minikube: 62.4s 57.1s 57.2s
Average time for minikube: 58.9s

Times for Minikube (PR 9723): 60.1s 55.5s 59.9s
Average time for Minikube (PR 9723): 58.5s

Averages Time Per Log

+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9723) |
+--------------------------------+----------+--------------------+
| * minikube v1.15.1 on Debian   | 0.1s     | 0.1s               |
|                           9.11 |          |                    |
| * Using the kvm2 driver based  | 0.0s     | 0.0s               |
| on user configuration          |          |                    |
| * Starting control plane node  | 0.0s     | 0.0s               |
| minikube in cluster minikube   |          |                    |
| * Creating kvm2 VM (CPUs=2,    | 35.7s    | 34.1s              |
| Memory=3700MB, Disk=20000MB)   |          |                    |
| ...                            |          |                    |
| * Preparing Kubernetes v1.19.4 | 21.1s    | 22.3s              |
| on Docker 19.03.13 ...         |          |                    |
| * Verifying Kubernetes         | 1.6s     | 1.5s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.4s     | 0.7s               |
| default-storageclass,          |          |                    |
| storage-provisioner            |          |                    |
|                                | 0.0s     | 0.0s               |
|   - Want kubectl v1.19.4? Try  |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| cluster and "default"          |          |                    |
| namespace by default           |          |                    |
+--------------------------------+----------+--------------------+

docker Driver
Times for minikube: 28.3s 28.3s 28.6s
Average time for minikube: 28.4s

Times for Minikube (PR 9723): 28.0s 29.4s 28.6s
Average time for Minikube (PR 9723): 28.7s

Averages Time Per Log

+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9723) |
+--------------------------------+----------+--------------------+
| * minikube v1.15.1 on Debian   | 0.2s     | 0.2s               |
|                           9.11 |          |                    |
| * Using the docker driver      | 0.1s     | 0.1s               |
| based on user configuration    |          |                    |
| * Starting control plane node  | 0.1s     | 0.1s               |
| minikube in cluster minikube   |          |                    |
| * Creating docker container    | 9.0s     | 8.9s               |
| (CPUs=2, Memory=3700MB) ...    |          |                    |
| * Preparing Kubernetes v1.19.4 | 17.8s    | 18.1s              |
| on Docker 19.03.13 ...         |          |                    |
| * Verifying Kubernetes         | 1.1s     | 1.2s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.1s     |                    |
| default-storageclass,          |          |                    |
| storage-provisioner            |          |                    |
|                                | 0.0s     | 0.0s               |
|   - Want kubectl v1.19.4? Try  |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| cluster and "default"          |          |                    |
| namespace by default           |          |                    |
+--------------------------------+----------+--------------------+

minikube-pr-bot · 2020-11-24T19:02:46Z

kvm2 Driver
Times for minikube: 58.8s 59.4s 60.4s
Average time for minikube: 59.5s

Times for Minikube (PR 9723): 55.6s 56.5s 53.8s
Average time for Minikube (PR 9723): 55.3s

Averages Time Per Log

+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9723) |
+--------------------------------+----------+--------------------+
| * minikube v1.15.1 on Debian   | 0.1s     | 0.1s               |
|                           9.11 |          |                    |
| * Using the kvm2 driver based  | 0.0s     | 0.0s               |
| on user configuration          |          |                    |
| * Starting control plane node  | 0.0s     | 0.0s               |
| minikube in cluster minikube   |          |                    |
| * Creating kvm2 VM (CPUs=2,    | 34.4s    | 31.0s              |
| Memory=3700MB, Disk=20000MB)   |          |                    |
| ...                            |          |                    |
| * Preparing Kubernetes v1.19.4 | 23.0s    | 22.7s              |
| on Docker 19.03.13 ...         |          |                    |
| * Verifying Kubernetes         | 1.5s     | 1.4s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.7s     | 0.2s               |
| storage-provisioner,           |          |                    |
| default-storageclass           |          |                    |
|                                | 0.0s     | 0.0s               |
|   - Want kubectl v1.19.4? Try  |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| cluster and "default"          |          |                    |
| namespace by default           |          |                    |
+--------------------------------+----------+--------------------+

docker Driver
Times for minikube: 29.0s 28.6s 28.9s
Average time for minikube: 28.8s

Times for Minikube (PR 9723): 27.8s 28.1s 29.5s
Average time for Minikube (PR 9723): 28.5s

Averages Time Per Log

+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9723) |
+--------------------------------+----------+--------------------+
| * minikube v1.15.1 on Debian   | 0.2s     | 0.2s               |
|                           9.11 |          |                    |
| * Using the docker driver      | 0.1s     | 0.1s               |
| based on user configuration    |          |                    |
| * Starting control plane node  | 0.1s     | 0.1s               |
| minikube in cluster minikube   |          |                    |
| * Creating docker container    | 8.8s     | 8.8s               |
| (CPUs=2, Memory=3700MB) ...    |          |                    |
| * Preparing Kubernetes v1.19.4 | 18.4s    | 18.0s              |
| on Docker 19.03.13 ...         |          |                    |
| * Verifying Kubernetes         | 1.2s     | 1.2s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.1s     | 0.1s               |
| storage-provisioner,           |          |                    |
| default-storageclass           |          |                    |
|                                | 0.1s     | 0.0s               |
|   - Want kubectl v1.19.4? Try  |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| cluster and "default"          |          |                    |
| namespace by default           |          |                    |
+--------------------------------+----------+--------------------+

medyagh · 2020-11-24T19:23:41Z

/ok-to-test

k8s-ci-robot · 2020-11-24T19:24:16Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, priyawadhwa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [medyagh,priyawadhwa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Priya Wadhwa added 2 commits November 16, 2020 20:31

Tracing compiles

0f23913

add --trace flag

c4dd42a

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 17, 2020

k8s-ci-robot requested review from medyagh and RA489 November 17, 2020 05:41

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2020

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Nov 17, 2020

Priya Wadhwa added 2 commits November 24, 2020 10:28

add doc around telemetry

9507e80

Merge branch 'master' of https://github.com/kubernetes/minikube into …

63e5021

…add-tracing

medyagh requested changes Nov 24, 2020

View reviewed changes

pkg/trace/gcp.go Show resolved Hide resolved

pkg/trace/gcp.go Show resolved Hide resolved

medyagh requested changes Nov 24, 2020

View reviewed changes

site/content/en/docs/tutorials/telemetry.md Outdated Show resolved Hide resolved

site/content/en/docs/tutorials/telemetry.md Outdated Show resolved Hide resolved

address review comments

3756707

medyagh reviewed Nov 24, 2020

View reviewed changes

update docs

5e13824

medyagh approved these changes Nov 24, 2020

View reviewed changes

priyawadhwa merged commit 61db8e7 into kubernetes:master Nov 25, 2020

priyawadhwa deleted the add-tracing branch November 25, 2020 00:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add OpenTelemetry tracing to minikube #9723

Add OpenTelemetry tracing to minikube #9723

priyawadhwa commented Nov 17, 2020 •

edited

Loading

priyawadhwa commented Nov 17, 2020

minikube-pr-bot commented Nov 17, 2020

medyagh Nov 24, 2020

priyawadhwa Nov 24, 2020

minikube-pr-bot commented Nov 24, 2020

minikube-pr-bot commented Nov 24, 2020

medyagh commented Nov 24, 2020

k8s-ci-robot commented Nov 24, 2020

Add OpenTelemetry tracing to minikube #9723

Add OpenTelemetry tracing to minikube #9723

Conversation

priyawadhwa commented Nov 17, 2020 • edited Loading

priyawadhwa commented Nov 17, 2020

minikube-pr-bot commented Nov 17, 2020

medyagh Nov 24, 2020

Choose a reason for hiding this comment

priyawadhwa Nov 24, 2020

Choose a reason for hiding this comment

minikube-pr-bot commented Nov 24, 2020

minikube-pr-bot commented Nov 24, 2020

medyagh commented Nov 24, 2020

k8s-ci-robot commented Nov 24, 2020

priyawadhwa commented Nov 17, 2020 •

edited

Loading