Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add per test suite measurements and use them for SLIs #796

Open
oxddr opened this issue Sep 12, 2019 · 5 comments
Open

Add per test suite measurements and use them for SLIs #796

oxddr opened this issue Sep 12, 2019 · 5 comments
Labels
area/clusterloader area/slo lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@oxddr
Copy link
Contributor

oxddr commented Sep 12, 2019

Currently we do measure all SLIs per test, but actually there is no reason not to run them per test suite. Benefits of having SLIs measure per test suite:

  • more data points - important especially in shorter tests, where we lack data points and they are prone to flakiness due to single spikes
  • more concise test configuration - measurements needs to be configured once

/area slo
/area clusterloader

@k8s-ci-robot
Copy link
Contributor

@oxddr: The label(s) area/ cannot be appled. These labels are supported: api-review, community/discussion, community/maintenance, community/question, cuj/build-train-deploy, cuj/multi-user, platform/aws, platform/azure, platform/gcp, platform/minikube, platform/other

In response to this:

Currently we do measure all SLIs per test, but actually there is no reason not to run them per test suite. Benefits of having SLIs measure per test suite:

  • more data points - important especially in shorter tests, where we lack data points and they are prone to flakiness due to single spikes
  • more concise test configuration - measurements needs to be configured once

/area slo
/area clusterloader

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 11, 2019
@oxddr
Copy link
Contributor Author

oxddr commented Dec 11, 2019

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 11, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 10, 2020
@wojtek-t
Copy link
Member

/remove-lifecycle stale
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/clusterloader area/slo lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

4 participants