Add pod update checking to WaitForControlledPodsRunning #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mborsz: GitHub didn't allow me to assign the following users: wojtekt-t. Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
/assign @wojtek-t |
wojtek-t
reviewed
Feb 7, 2020
| @@ -108,6 +110,12 @@ func (w *waitForControlledPodsRunningMeasurement) Execute(config *measurement.Me | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
| // default value is set to true to let presubmit validate this change. | |||
| // TODO(mborsz): Change default to false before submitting. | |||
There was a problem hiding this comment.
Note to myself - ensure it's removed before lgtm-ing.
There was a problem hiding this comment.
We should also add a TODO to make the default true eventually.
Maybe we shouldn't do that on Friday, but once we get enough confidence we should enabled it by default as it's the right way to do.
mm4tt
reviewed
Feb 7, 2020
| @@ -108,6 +110,12 @@ func (w *waitForControlledPodsRunningMeasurement) Execute(config *measurement.Me | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
| // default value is set to true to let presubmit validate this change. | |||
| // TODO(mborsz): Change default to false before submitting. | |||
There was a problem hiding this comment.
We should also add a TODO to make the default true eventually.
Maybe we shouldn't do that on Friday, but once we get enough confidence we should enabled it by default as it's the right way to do.
clusterloader2/pkg/measurement/util/runtimeobjects/runtimeobjects.go
Outdated
Show resolved
Hide resolved
mm4tt
reviewed
Feb 7, 2020
|
I finished manual tests of this. It seems to work. FTR yamls I used to test this: # config.yaml
name test:
automanagedNamespaces: 1
tuningSets:
- name: 100qps
GlobalQPSLoad:
qps: 100
burst: 10
- name: RandomizedUpdateTimeLimited
RandomizedTimeLimitedLoad:
timeLimit: 2h
steps:
- name: Starting measurement for waiting for pods
measurements:
- Identifier: WaitForRunningMicroservices
Method: WaitForControlledPodsRunning
Params:
action: start
apiVersion: apps/v1
kind: Deployment
labelSelector: l1 = v1
operationTimeout: 1h
- name: Create Foos
phases:
- namespaceRange:
min: 1
max: 1
replicasPerNamespace: 1
tuningSet: 100qps
objectBundle:
- basename: foo
objectTemplatePath: foo.yaml
templateFillMap:
env: old
- name: Waiting for objects become updated
measurements:
- Identifier: WaitForRunningMicroservices
Method: WaitForControlledPodsRunning
Params:
action: gather
- name: Update Foos
phases:
- namespaceRange:
min: 1
max: 1
replicasPerNamespace: 1
tuningSet: 100qps
objectBundle:
- basename: foo
objectTemplatePath: foo.yaml
templateFillMap:
env: new
- name: Waiting for objects become updated
measurements:
- Identifier: WaitForRunningMicroservices
Method: WaitForControlledPodsRunning
Params:
action: gather
# foo.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
name: example-foo
labels:
l1: v1
spec:
selector:
matchLabels:
l1: v1
replicas: 3
template:
metadata:
labels:
l1: v1
spec:
containers:
- image: k8s.gcr.io/pause:3.1
name: test
env:
- name: XX
value: {{.env}}
resources:
limits:
cpu: 10mThe most interesting log entries: |
mborsz
added a commit
to mborsz/perf-tests
that referenced
this pull request
Feb 7, 2020
This is unnecessary (daemoset controller adds this toleration anyway) and breaks kubernetes#1035
mborsz
added a commit
to mborsz/perf-tests
that referenced
this pull request
Feb 7, 2020
This is unnecessary (daemoset controller adds this toleration anyway) and breaks kubernetes#1035
|
/hold cancel I tested this, changed default back to false. |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mborsz, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements an experimental support for waiting for pod updates in WaitForControlledPodsRunning.
The new logic is enabled by setting
checkIfPodsAreUpdated: trueflag (name TBD).At this point, nothing special happens.
Let's trigger some update:
The
gathercall will block here untilreplicaspods exist in given deployment that match deployment's spec.template.spec.Without this change, we would wait only for any
replicaspod exist in given deployment (regardless if they are updated or not) which is not correct./assign @wojtekt-t
/assign @mm4tt