clusterloader2: drop metrics deprecated in 1.19 #1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
Collected metrics contain the following entries for binding and predicate evaluation: |
ingvagabund
force-pushed
the
scheduler-drop-deprecated-metrics
branch
3 times, most recently
from
a490d22
to
8e0aa84
Compare
|
@ahg-g PTAL |
|
As per #1081 (comment) comment, do you want to display the deprecated binding/preemption metrics with the new ones? Right now, the old metrics are just replaced by the new ones. |
ahg-g
reviewed
Apr 13, 2020
| @@ -42,7 +41,8 @@ const ( | |||
| e2eSchedulingDurationMetricName = model.LabelValue(schedulermetric.SchedulerSubsystem + "_e2e_scheduling_duration_seconds_bucket") | |||
| schedulingAlgorithmDurationMetricName = model.LabelValue(schedulermetric.SchedulerSubsystem + "_scheduling_algorithm_duration_seconds_bucket") | |||
| frameworkExtensionPointDurationMetricName = model.LabelValue(schedulermetric.SchedulerSubsystem + "_framework_extension_point_duration_seconds_bucket") | |||
| schedulingLatencyMetricName = model.LabelValue(schedulermetric.SchedulerSubsystem + "_" + schedulermetric.DeprecatedSchedulingDurationName) | |||
| bindingDurationMetricName = model.LabelValue(schedulermetric.SchedulerSubsystem + "_binding_duration_seconds_bucket") | |||
There was a problem hiding this comment.
binding is already one of the extension points, so we don't really need a separate metric for it.
Both predicate_evaluation and priority_evaluation operation metrics are replaced with filter, resp. score extension points. Also, preemption_evaluation, resp. binding operation metrics are replaced with scheduler_scheduling_algorithm_preemption_evaluation_seconds_bucket, resp. scheduler_binding_duration_seconds_bucket metrics.
ingvagabund
force-pushed
the
scheduler-drop-deprecated-metrics
branch
from
8e0aa84
to
73e8002
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@wojtek-t PTAL |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, ingvagabund, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
|
@mm4tt can you please reload perfdash? |
mm4tt
added a commit
to mm4tt/perf-tests
that referenced
this pull request
Apr 20, 2020
This is to include kubernetes#1172
Merged
mm4tt
added a commit
to mm4tt/perf-tests
that referenced
this pull request
Apr 20, 2020
This is to include kubernetes#1172
yuanchen8911
pushed a commit
to yuanchen8911/perf-tests
that referenced
this pull request
Apr 20, 2020
This is to include kubernetes#1172
vamossagar12
pushed a commit
to vamossagar12/perf-tests
that referenced
this pull request
Apr 24, 2020
This is to include kubernetes#1172
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both predicate_evaluation and priority_evaluation operation metrics are replaced
with filter, resp. score extension points.
Also, preemption_evaluation, resp. binding operation metrics are replaced with
scheduler_scheduling_algorithm_preemption_evaluation_seconds_bucket, resp.
scheduler_binding_duration_seconds_bucket metrics.