-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass proper GCP project with snapshots storage to PrometheusController #1178
Pass proper GCP project with snapshots storage to PrometheusController #1178
Conversation
Hi @tosi3k. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
dd9f9db
to
170f088
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tosi3k, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
When using pod-utils for SIG scalability test jobs, clusterloader was attempting to snapshot Prometheus' PDs to Prow cluster project. The proposed flag
experimental-snapshot-project
(which defaults toPROJECT
environment variable value which is set here) is added to be utilized by gcloud command that performs snapshotting./sig scalability