clusterloader: enable the use of pre-created namespaces #1181
Conversation
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @yuanchen8911. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
cncf-cla: yes
|
/assign @wojtek-t |
clusterloader2/api/types.go
Outdated
| @@ -116,10 +116,12 @@ type NamespaceConfig struct { | |||
| // NamePrefix is the name prefix of automanaged namespaces. | |||
| // It's optional, if set CL will use it, otherwise generate one with random string. | |||
| Prefix string `json: prefix,omitempty` | |||
| // DeleteStaleNamespaces specifies whether or not delete stale namepaces | |||
| // DeleteStaleNamespaces specifies whether or not delete stale namepaces. | |||
There was a problem hiding this comment.
nit: actually can you fix all of these to "namespaces"
There was a problem hiding this comment.
@coltonstapper fixed. thanks!
|
/assign @wojtek-t |
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wojtek-t, yuanchen8911 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This PR is to enhance clusterloader to support the use of existing namespaces in a test.
A new flag "EnableExistingNamespaces" is added. If set, pre-created namespaces with the specified prefix will be used if existing. If the specified namespace doesn't exist, a new one is created.
Please refer to PR #1173 # and Issue #1169 for the related discussions.