-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add aggregated graphs to master dashboard #1188
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Thanks!
clusterloader2/pkg/prometheus/manifests/dashboards/master-dashboard.dashboard.py
Outdated
Show resolved
Hide resolved
clusterloader2/pkg/prometheus/manifests/dashboards/master-dashboard.dashboard.py
Outdated
Show resolved
Hide resolved
d9785ce
to
49998fe
Compare
/retest |
clusterloader2/pkg/prometheus/manifests/dashboards/master-dashboard.dashboard.py
Outdated
Show resolved
Hide resolved
49998fe
to
2ae8ee6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No more minor comment, otherwise LGTM.
clusterloader2/pkg/prometheus/manifests/dashboards/master-dashboard.dashboard.py
Outdated
Show resolved
Hide resolved
2ae8ee6
to
8fa4c1a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two nits, other than that LGTM.
clusterloader2/pkg/prometheus/manifests/dashboards/master-dashboard.dashboard.py
Show resolved
Hide resolved
clusterloader2/pkg/prometheus/manifests/dashboards/master-dashboard.dashboard.py
Outdated
Show resolved
Hide resolved
f721812
to
c365bd4
Compare
c365bd4
to
d30e202
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jprzychodzen, oxddr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @mm4tt
Add a set of new graphs to Graphana dashboard, using
quantile_over_time(0.99,
query.