Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aggregated graphs to master dashboard #1188

Merged
merged 1 commit into from
Apr 30, 2020

Conversation

jprzychodzen
Copy link
Contributor

/assign @mm4tt

Add a set of new graphs to Graphana dashboard, using quantile_over_time(0.99, query.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 23, 2020
Copy link
Contributor

@mm4tt mm4tt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Thanks!

@jprzychodzen jprzychodzen force-pushed the new-graphs branch 2 times, most recently from d9785ce to 49998fe Compare April 23, 2020 11:48
@jprzychodzen
Copy link
Contributor Author

/retest

Copy link
Contributor

@oxddr oxddr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more minor comment, otherwise LGTM.

Copy link
Contributor

@oxddr oxddr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nits, other than that LGTM.

@oxddr
Copy link
Contributor

oxddr commented Apr 30, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 30, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jprzychodzen, oxddr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2020
@k8s-ci-robot k8s-ci-robot merged commit 6c02284 into kubernetes:master Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants