Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set --private-bucket for pushing golang builds #1193

Merged
merged 1 commit into from
Apr 28, 2020
Merged

Set --private-bucket for pushing golang builds #1193

merged 1 commit into from
Apr 28, 2020

Conversation

mm4tt
Copy link
Contributor

@mm4tt mm4tt commented Apr 28, 2020

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 28, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2020
@tosi3k
Copy link
Member

tosi3k commented Apr 28, 2020

/lgtm

@k8s-ci-robot
Copy link
Contributor

@tosi3k: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mborsz
Copy link
Member

mborsz commented Apr 28, 2020

/lgtm

1 similar comment
@jkaniuk
Copy link
Contributor

jkaniuk commented Apr 28, 2020

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkaniuk, mborsz, mm4tt, tosi3k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Apr 28, 2020
@k8s-ci-robot k8s-ci-robot merged commit 8f38a30 into kubernetes:master Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmarek gmarek Awaiting requested review from gmarek

@timothysc timothysc Awaiting requested review from timothysc

Assignees

@mborsz mborsz

@jkaniuk jkaniuk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mm4tt @tosi3k @k8s-ci-robot @mborsz @jkaniuk